Skip to content

Fix addmm_cpu for int64#75200

Closed
lezcano wants to merge 6 commits intogh/Lezcano/60/basefrom
gh/Lezcano/60/head
Closed

Fix addmm_cpu for int64#75200
lezcano wants to merge 6 commits intogh/Lezcano/60/basefrom
gh/Lezcano/60/head

Conversation

@lezcano
Copy link
Collaborator

@lezcano lezcano commented Apr 4, 2022 •
edited by ngimel
Loading

@lezcano
Fix addmm_cpu for int64
41f824c 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Apr 4, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 99008a3 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Apr 4, 2022
Closed
Closed
Closed
Closed
@lezcano lezcano requested review from ngimel and removed request for IvanYashchuk and nikitaved April 4, 2022 16:53
@lezcano lezcano added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul topic: bug fixes topic category labels Apr 4, 2022
@lezcano
Update on "Fix addmm_cpu for int64"
5d62081 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Apr 4, 2022
Closed
lezcano added 2 commits April 4, 2022 22:01
@lezcano
Update on "Fix addmm_cpu for int64"
2923f43 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@lezcano
Update on "Fix addmm_cpu for int64"
d4c7541 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Apr 5, 2022
Closed
lezcano added 2 commits April 6, 2022 14:22
@lezcano
Update on "Fix addmm_cpu for int64"
d794aa1 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@lezcano
Update on "Fix addmm_cpu for int64"
99008a3 
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

[ghstack-poisoned]
@ngimel
Copy link
Collaborator

ngimel commented Apr 6, 2022

Is this a fix for #71774?

@lezcano
Copy link
Collaborator Author

lezcano commented Apr 7, 2022

It is indeed!

@ngimel
Copy link
Collaborator

ngimel commented Apr 7, 2022

@pytorchbot merge this please

@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2022

Hey @lezcano.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Apr 7, 2022
@lezcano @facebook-github-bot
Fix addmm_cpu for int64 (#75200)
9392b58 
Summary:
There was a bug for the case [a, 0] x [0, b] in addmm_cpu. We implement
a short-cut for this case.

Pull Request resolved: #75200

Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/e0f9c69fcf9384a7d7e64ebacb219c11fc7ea928

Reviewed By: b0noI

Differential Revision: D35469394

fbshipit-source-id: 6edb0c43b4d599ff7cd4423e660f439a16bd3cc6
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/60/head branch April 11, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lezcano @facebook-github-bot @ngimel @pytorchbot