Skip to content

Go through the dispatcher in matmul_out for the 1D-1D case#75196

Closed
lezcano wants to merge 10 commits intogh/Lezcano/58/basefrom
gh/Lezcano/58/head
Closed

Go through the dispatcher in matmul_out for the 1D-1D case#75196
lezcano wants to merge 10 commits intogh/Lezcano/58/basefrom
gh/Lezcano/58/head

Conversation

@lezcano
Copy link
Collaborator

@lezcano lezcano commented Apr 4, 2022 •
edited
Loading

@lezcano
Go through the dispatcher in matmul_out for the 1D-1D case
4770eca 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
This was referenced Apr 4, 2022
Closed
Closed
Closed
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 4, 2022 •
edited
Loading

🔗 Helpful links

💊 CI failures summary and remediations

As of commit 23ac5fe (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / pytorch-xla-linux-bionic-py3.7-clang8 / test (xla, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-05-04T20:32:45.9320382Z �[0;31m[ FAILED ] �[mAtenXlaTensorTest.TestMatmul_1x2 
2022-05-04T20:32:45.9311808Z �[0;32m[ RUN      ] �[mXlaUtilCacheTest.BasicTest
2022-05-04T20:32:45.9313409Z �[0;32m[       OK ] �[mXlaUtilCacheTest.BasicTest (0 ms)
2022-05-04T20:32:45.9314241Z �[0;32m[----------] �[m1 test from XlaUtilCacheTest (0 ms total)
2022-05-04T20:32:45.9314760Z 
2022-05-04T20:32:45.9315099Z �[0;32m[----------] �[mGlobal test environment tear-down
2022-05-04T20:32:45.9317624Z �[0;32m[==========] �[m623 tests from 8 test suites ran. (503082 ms total)
2022-05-04T20:32:45.9318096Z �[0;32m[  PASSED  ] �[m621 tests.
2022-05-04T20:32:45.9318626Z �[0;32m[  SKIPPED ] �[m1 test, listed below:
2022-05-04T20:32:45.9319279Z �[0;32m[  SKIPPED ] �[mAtenXlaTensorTest.TestGroupNormBackward
2022-05-04T20:32:45.9319907Z �[0;31m[  FAILED  ] �[m1 test, listed below:
2022-05-04T20:32:45.9320382Z �[0;31m[  FAILED  ] �[mAtenXlaTensorTest.TestMatmul_1x2
2022-05-04T20:32:45.9320762Z 
2022-05-04T20:32:45.9320876Z  1 FAILED TEST
2022-05-04T20:32:46.1195638Z + cleanup
2022-05-04T20:32:46.1195846Z + retcode=1
2022-05-04T20:32:46.1196012Z + set +x
2022-05-04T20:32:46.1998406Z ##[error]Process completed with exit code 1.
2022-05-04T20:32:46.2127765Z ##[group]Run pytorch/pytorch/.github/actions/get-workflow-job-id@master
2022-05-04T20:32:46.2128007Z with:
2022-05-04T20:32:46.2128338Z   github-token: ***
2022-05-04T20:32:46.2128511Z env:
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@lezcano lezcano added module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul topic: not user facing topic category release notes: performance_as_product topic: performance topic category and removed topic: not user facing topic category labels Apr 4, 2022
@lezcano lezcano mentioned this pull request Apr 4, 2022
Closed
lezcano added 2 commits April 4, 2022 16:52
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
3bfb29e 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
e3ce7d2 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Apr 4, 2022
Closed
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
e2489b5 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@IvanYashchuk IvanYashchuk removed their request for review April 5, 2022 06:20
lezcano added 2 commits April 5, 2022 18:03
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
b305322 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
c566b3a 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request Apr 5, 2022
Closed
lezcano added 3 commits April 6, 2022 14:22
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
b43e5ed 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
33e8809 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
2ced48b 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano
Update on "Go through the dispatcher in matmul_out for the 1D-1D case"
23ac5fe 
Putting this one separate as it may break things like mobile.

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request May 4, 2022
Closed
@lezcano
Copy link
Collaborator Author

lezcano commented May 5, 2022

@pytorchmergebot merge this please

@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/58/head branch May 8, 2022 14:16
facebook-github-bot pushed a commit that referenced this pull request May 8, 2022
@lezcano @facebook-github-bot
Go through the dispatcher in matmul_out for the 1D-1D case (#75196)
0bb191c 
Summary:
Putting this one separate as it may break things like mobile.

Pull Request resolved: #75196

Approved by: https://github.com/ngimel

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2b3b205f18e8b46ee1cb7056f1460ae70407d0d6

Reviewed By: malfet

Differential Revision: D36171119

fbshipit-source-id: 26a93e4194fccb41b754b7a3be75a0dc9d6feef9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@nikitaved nikitaved Awaiting requested review from nikitaved

Assignees

No one assigned

Labels

cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source topic: performance topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lezcano @facebook-github-bot @ngimel @pytorchbot