Skip to content

Fix mv/addmv on CUDA when dealing with vectors of size=1 and stride=0#75279

Closed
lezcano wants to merge 5 commits intogh/Lezcano/62/basefrom
gh/Lezcano/62/head
Closed

Fix mv/addmv on CUDA when dealing with vectors of size=1 and stride=0#75279
lezcano wants to merge 5 commits intogh/Lezcano/62/basefrom
gh/Lezcano/62/head

Conversation

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 5, 2022

🔗 Helpful links

💊 CI failures summary and remediations

As of commit bc1ff56 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

lezcano added 2 commits April 6, 2022 14:22
…nd stride=0"

This fix was suggested by peterbell10

[ghstack-poisoned]
…nd stride=0"

This fix was suggested by peterbell10

[ghstack-poisoned]
@ngimel
Copy link
Collaborator

ngimel commented Apr 8, 2022

@lezcano can you please separate this PR from the stack so that I can land it sooner? (We want to enable more out tests in OpInfos, cc @mruberry)

@lezcano
Copy link
Collaborator Author

lezcano commented Apr 8, 2022

I don't think this one solves any out= issues. Do you perhaps mean #75195 ?
Also, the previous PRs in the stack should not require much effort to merge but perhaps just taking a decision on what to do with #75220. If you tell me what's the right thing to do, we should be able to have all the stack (but perhaps the last PR) ready to be merged just today.

lezcano added 2 commits April 21, 2022 13:08
…nd stride=0"

This fix was suggested by peterbell10

[ghstack-poisoned]
…nd stride=0"

This fix was suggested by peterbell10

[ghstack-poisoned]
@lezcano lezcano mentioned this pull request May 4, 2022
@ngimel
Copy link
Collaborator

ngimel commented May 4, 2022

@pytorchbot merge this

facebook-github-bot pushed a commit that referenced this pull request May 6, 2022
…#75279)

Summary:
This fix was suggested by peterbell10

Pull Request resolved: #75279

Approved by: https://github.com/ezyang

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/02b5b92c65cc346f36f5982bc82ca9ecacde6515

Reviewed By: malfet

Differential Revision: D36171114

fbshipit-source-id: ced98fa519b85f5cb4c026e15054bc39b93ae50b
@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/62/head branch May 8, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: linear algebra Issues related to specialized linear algebra operations in PyTorch; includes matrix multiply matmul open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants