[ONNX] Minor doc update (#69501) by BowenBao · Pull Request #69550 · pytorch/pytorch

BowenBao · 2021-12-07T18:25:43Z

Stack from ghstack:

Fix the wiki URL.

Also minor reorganization in onnx.rst.

Differential Revision: D32994269

Fix the wiki URL. Also minor reorganization in onnx.rst. [ghstack-poisoned]

facebook-github-bot · 2021-12-07T18:26:07Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/69550
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 03c8bfc (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 28aed77 Pull Request resolved: #69550

BowenBao · 2021-12-08T01:03:41Z

cc @garymm this one seems to have some CI error with linux-docs / build-docs (python).

@msaroufim please leave out that one and import from #69549

garymm · 2021-12-08T18:49:04Z

cc @garymm this one seems to have some CI error with linux-docs / build-docs (python).

Sorry about that. Attempting to fix here: #69623

Fix the wiki URL. Also minor reorganization in onnx.rst. [ghstack-poisoned]

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'

pytorch-probot · 2021-12-09T00:41:54Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/5b5597e92a013b6e930ab7c5fed457b8d0753863/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries/conda`	🚫 skipped
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries/libtorch`	🚫 skipped
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries/libtorch`	🚫 skipped
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries/wheel`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

BowenBao · 2021-12-09T00:43:13Z

Should resolve doc CI issues now, squashing the fix from @garymm.

@msaroufim please directly import this PR stack.

msaroufim · 2021-12-09T18:56:18Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'

Fix the wiki URL. Also minor reorganization in onnx.rst. Differential Revision: [D32994269](https://our.internmc.facebook.com/intern/diff/D32994269) [ghstack-poisoned]

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 3a50aac Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'

msaroufim · 2022-01-07T21:11:08Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

BowenBao · 2022-01-21T02:04:59Z

cannot merge this one separately unfortunately due to dependency on #68491

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'

Fix the wiki URL. Also minor reorganization in onnx.rst. Differential Revision: [D32994269](https://our.internmc.facebook.com/intern/diff/D32994269) [ghstack-poisoned]

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 30a29f2 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'

malfet · 2022-02-10T19:38:58Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #69550 Fix the wiki URL. Also minor reorganization in onnx.rst. Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994269 Pulled By: malfet fbshipit-source-id: 112acfe8b7c778d7e3c2cef684023fdaf2c6ec9c

github-actions · 2022-02-11T22:05:54Z

Hey @BowenBao.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: Pull Request resolved: pytorch/pytorch#69550 Fix the wiki URL. Also minor reorganization in onnx.rst. Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994269 Pulled By: malfet fbshipit-source-id: 112acfe8b7c778d7e3c2cef684023fdaf2c6ec9c (cherry picked from commit f0787fabde906bdd9e14fb95cee5ebdfc770f75b)

[ONNX] Minor doc update (#69501)

cb526ca

Fix the wiki URL. Also minor reorganization in onnx.rst. [ghstack-poisoned]

BowenBao requested a review from shubhambhokare1 as a code owner December 7, 2021 18:25

facebook-github-bot added the cla signed label Dec 7, 2021

BowenBao added a commit that referenced this pull request Dec 7, 2021

[ONNX] Minor doc update (#69501)

1614385

Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 28aed77 Pull Request resolved: #69550

pytorchbot added the open source label Dec 7, 2021

Update on "[ONNX] Minor doc update (#69501)"

e511fe8

Fix the wiki URL. Also minor reorganization in onnx.rst. [ghstack-poisoned]

pytorch-probot bot added the ciflow/default label Dec 9, 2021

Update on "[ONNX] Minor doc update (#69501)"

c54a410

Fix the wiki URL. Also minor reorganization in onnx.rst. Differential Revision: [D32994269](https://our.internmc.facebook.com/intern/diff/D32994269) [ghstack-poisoned]

Update on "[ONNX] Minor doc update (#69501)"

03c8bfc

Fix the wiki URL. Also minor reorganization in onnx.rst. Differential Revision: [D32994269](https://our.internmc.facebook.com/intern/diff/D32994269) [ghstack-poisoned]

BowenBao mentioned this pull request Feb 10, 2022

[ONNX] Link to the wiki (#68505) #72663

Closed

pytorchmergebot closed this in 9257de7 Feb 11, 2022

facebook-github-bot deleted the gh/BowenBao/176/head branch February 15, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Minor doc update (#69501)#69550

[ONNX] Minor doc update (#69501)#69550
BowenBao wants to merge 5 commits intogh/BowenBao/176/basefrom
gh/BowenBao/176/head

BowenBao commented Dec 7, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 7, 2021 •

edited

Loading

Uh oh!

BowenBao commented Dec 8, 2021

Uh oh!

garymm commented Dec 8, 2021

Uh oh!

pytorch-probot bot commented Dec 9, 2021 •

edited

Loading

⚛️ CI Flow

Uh oh!

BowenBao commented Dec 9, 2021

Uh oh!

msaroufim commented Dec 9, 2021

Uh oh!

msaroufim commented Jan 7, 2022

Uh oh!

BowenBao commented Jan 21, 2022

Uh oh!

malfet commented Feb 10, 2022

Uh oh!

github-actions bot commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

BowenBao commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

BowenBao commented Dec 8, 2021

Uh oh!

garymm commented Dec 8, 2021

Uh oh!

pytorch-probot bot commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

BowenBao commented Dec 9, 2021

Uh oh!

msaroufim commented Dec 9, 2021

Uh oh!

msaroufim commented Jan 7, 2022

Uh oh!

BowenBao commented Jan 21, 2022

Uh oh!

malfet commented Feb 10, 2022

Uh oh!

github-actions bot commented Feb 11, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

BowenBao commented Dec 7, 2021 •

edited

Loading

facebook-github-bot commented Dec 7, 2021 •

edited

Loading

pytorch-probot bot commented Dec 9, 2021 •

edited

Loading