[ONNX] restore documentation of public functions#69623
Merged
garymm merged 1 commit intopytorch:onnx_ms_1from Dec 8, 2021
Merged
[ONNX] restore documentation of public functions#69623garymm merged 1 commit intopytorch:onnx_ms_1from
garymm merged 1 commit intopytorch:onnx_ms_1from
Conversation
The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 3add25f (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Report results | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
BowenBao
approved these changes
Dec 8, 2021
Collaborator
BowenBao
left a comment
There was a problem hiding this comment.
LGTM, thanks for quick fix!
Collaborator
Author
|
|
Collaborator
|
squashing with previous PR to merge to master |
BowenBao
added a commit
that referenced
this pull request
Dec 9, 2021
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
that referenced
this pull request
Jan 7, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 3a50aac Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
that referenced
this pull request
Jan 11, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: f10c103 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
that referenced
this pull request
Jan 21, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: f10c103 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Summary: Fix the wiki URL. Also minor reorganization in onnx.rst. [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.' Pull Request resolved: #71609 Test Plan: automation Reviewed By: bigfootjon Differential Revision: D33714218 fbshipit-source-id: d2bec70fe5e0f69ced6cfb9ac385d6425e770cab
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 31, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: e59c7f1 Pull Request resolved: pytorch#69550 [ONNX] restore documentation of public functions (pytorch#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
garymm
added a commit
to garymm/pytorch
that referenced
this pull request
Feb 9, 2022
The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
BowenBao
added a commit
that referenced
this pull request
Feb 10, 2022
Fix the wiki URL. Also minor reorganization in onnx.rst. ghstack-source-id: 30a29f2 Pull Request resolved: #69550 [ONNX] restore documentation of public functions (#69623) The build-docs check requires all public functions to be documented. These should really not be public, but we'll fix that later.'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build-docs check requires all public functions to be documented.
These should really not be public, but we'll fix that later.'