[ONNX] Add Concat to Scalar type analysis JIT pass (#69227) by BowenBao · Pull Request #69548 · pytorch/pytorch

BowenBao · 2021-12-07T18:25:36Z

Stack from ghstack:

[ONNX] Minor doc update (#69501) #69550
-> [ONNX] Add Concat to Scalar type analysis JIT pass (#69227) #69548
[ONNX] De-duplicate initializers (#68202) #69547
[ONNX] Link to the wiki (#68505) #72663
[ONNX] Refactor _run_symbolic_function (#67573) #68491
Add Concat to Scalar type analysis pass

By using scalar type analysis for Concat, the exported model can do
automatic type promotion for Concat nodes, including mixed fp16 and fp32
inputs, for example.

Unit tests based on the original PR #24378

Fix UTs

Differential Revision: D32994268

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs [ghstack-poisoned]

facebook-github-bot · 2021-12-07T18:25:53Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/69548
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 45bb215 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

msaroufim · 2021-12-09T18:56:03Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]

pytorch-probot · 2022-01-07T00:11:41Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/e4ce1694874ce9868030199fb2e3c34c76f2148a/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/trunk`	✅ triggered
linux-docs	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/docs`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-vulkan-bionic-py3.7-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`, `ciflow/vulkan`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-cuda11.3-py3.7-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-build	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3-clang5-mobile-custom-build-static	`ciflow/all`, `ciflow/default`, `ciflow/linux`, `ciflow/mobile`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-asan	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/sanitizers`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-clang7-onnx	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/onnx`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
linux-xenial-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-custom-build-single-full-jit	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/trunk`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/trunk`, `ciflow/win`	✅ triggered
Skipped Workflows
caffe2-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
docker-builds	`ciflow/all`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-custom-ops	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-arm64-metal	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-coreml	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
ios-12-5-1-x86-64-full-jit	`ciflow/all`, `ciflow/ios`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda10.2-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
linux-binary-conda	`ciflow/binaries`, `ciflow/binaries/conda`	🚫 skipped
linux-binary-libtorch-cxx11-abi	`ciflow/binaries`, `ciflow/binaries/libtorch`	🚫 skipped
linux-binary-libtorch-pre-cxx11	`ciflow/binaries`, `ciflow/binaries/libtorch`	🚫 skipped
linux-binary-manywheel	`ciflow/binaries`, `ciflow/binaries/wheel`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`, `ciflow/trunk`	🚫 skipped
linux-docs-push	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
linux-xenial-cuda11.3-py3.7-gcc7-no-ops	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-arm64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-10-15-py3-lite-interpreter-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
macos-11-py3-x86-64	`ciflow/all`, `ciflow/macos`, `ciflow/trunk`	🚫 skipped
parallelnative-linux-xenial-py3.7-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped
periodic-libtorch-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-bionic-cuda11.5-py3.7-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda10.2-py3-gcc7-slow-gradcheck	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`, `ciflow/slow`, `ciflow/slow-gradcheck`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.7-gcc7-debug	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
periodic-win-vs2019-cuda11.5-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
pytorch-linux-xenial-py3-clang5-android-ndk-r19c-build	`ciflow/all`, `ciflow/android`, `ciflow/cpu`, `ciflow/linux`, `ciflow/trunk`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

msaroufim · 2022-01-07T21:10:49Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]

msaroufim · 2022-01-13T18:43:07Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

msaroufim · 2022-01-13T18:48:53Z

@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548

* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]

malfet · 2022-02-10T19:38:54Z

@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: Pull Request resolved: #69548 * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994268 Pulled By: malfet fbshipit-source-id: 0deab88b0bb1e396770690af27730accb64fcf63

Summary: Pull Request resolved: pytorch/pytorch#69548 * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch/pytorch#24378 * Fix UTs Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994268 Pulled By: malfet fbshipit-source-id: 0deab88b0bb1e396770690af27730accb64fcf63 (cherry picked from commit a99322cadf7b79a4548266a9d4d3af094b89bac4)

BowenBao requested a review from shubhambhokare1 as a code owner December 7, 2021 18:25

facebook-github-bot added the cla signed label Dec 7, 2021

BowenBao mentioned this pull request Dec 7, 2021

[ONNX] shapeValueMap: Represent symbolic shape as value (#68203) #69545

Closed

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 7, 2021

This was referenced Dec 7, 2021

[ONNX] Remove f arg from export_to_pretty_string (#69045) #69546

Closed

[ONNX] De-duplicate initializers (#68202) #69547

Closed

[ONNX] minor clarifications of docstrings (#69260) #69549

Closed

[ONNX] Minor doc update (#69501) #69550

Closed

pytorchbot added the open source label Dec 7, 2021

pytorch-probot bot added the ciflow/default label Jan 7, 2022

BowenBao mentioned this pull request Feb 10, 2022

[ONNX] Link to the wiki (#68505) #72663

Closed

pytorchmergebot closed this in 7884c2b Feb 11, 2022

facebook-github-bot deleted the gh/BowenBao/174/head branch February 15, 2022 15:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Add Concat to Scalar type analysis JIT pass (#69227)#69548

[ONNX] Add Concat to Scalar type analysis JIT pass (#69227)#69548
BowenBao wants to merge 4 commits intogh/BowenBao/174/basefrom
gh/BowenBao/174/head

BowenBao commented Dec 7, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Dec 7, 2021 •

edited

Loading

Uh oh!

msaroufim commented Dec 9, 2021

Uh oh!

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading

⚛️ CI Flow

Uh oh!

msaroufim commented Jan 7, 2022

Uh oh!

msaroufim commented Jan 13, 2022

Uh oh!

msaroufim commented Jan 13, 2022

Uh oh!

malfet commented Feb 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

BowenBao commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Dec 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

Uh oh!

msaroufim commented Dec 9, 2021

Uh oh!

pytorch-probot bot commented Jan 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

msaroufim commented Jan 7, 2022

Uh oh!

msaroufim commented Jan 13, 2022

Uh oh!

msaroufim commented Jan 13, 2022

Uh oh!

malfet commented Feb 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

BowenBao commented Dec 7, 2021 •

edited

Loading

facebook-github-bot commented Dec 7, 2021 •

edited

Loading

pytorch-probot bot commented Jan 7, 2022 •

edited

Loading