[ONNX] Add Concat to Scalar type analysis JIT pass#69227
Merged
thiagocrepaldi merged 2 commits intopytorch:onnx_ms_1from Dec 3, 2021
Merged
[ONNX] Add Concat to Scalar type analysis JIT pass#69227thiagocrepaldi merged 2 commits intopytorch:onnx_ms_1from
thiagocrepaldi merged 2 commits intopytorch:onnx_ms_1from
Conversation
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit ae7ad63 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Unknown | 🔁 rerun | |
| Report results | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
garymm
requested changes
Dec 1, 2021
Collaborator
garymm
left a comment
There was a problem hiding this comment.
Test failure TestONNXOpset.test_interpolate may be related.
915d2aa to
0158789
Compare
By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378
0158789 to
40d4981
Compare
garymm
approved these changes
Dec 1, 2021
Collaborator
garymm
left a comment
There was a problem hiding this comment.
LGTM, but please make sure ONNX tests pass before merging.
Collaborator
Author
all CIs are green. Merging |
BowenBao
added a commit
that referenced
this pull request
Dec 7, 2021
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs [ghstack-poisoned]
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548
BowenBao
added a commit
that referenced
this pull request
Jan 7, 2022
…JIT pass (#69227)" * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 7, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 11, 2022
…JIT pass (#69227)" * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 11, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 21, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 31, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR pytorch#24378 * Fix UTs ghstack-source-id: 4e796b1 Pull Request resolved: pytorch#69548
BowenBao
added a commit
that referenced
this pull request
Feb 10, 2022
…JIT pass (#69227)" * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Feb 10, 2022
* Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Differential Revision: [D32994268](https://our.internmc.facebook.com/intern/diff/D32994268) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Feb 11, 2022
Summary: Pull Request resolved: #69548 * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994268 Pulled By: malfet fbshipit-source-id: 0deab88b0bb1e396770690af27730accb64fcf63
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 11, 2022
Summary: Pull Request resolved: #69548 * Add Concat to Scalar type analysis pass By using scalar type analysis for Concat, the exported model can do automatic type promotion for Concat nodes, including mixed fp16 and fp32 inputs, for example. Unit tests based on the original PR #24378 * Fix UTs Test Plan: Imported from OSS Reviewed By: msaroufim Differential Revision: D32994268 Pulled By: malfet fbshipit-source-id: 0deab88b0bb1e396770690af27730accb64fcf63 (cherry picked from commit a99322c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using scalar type analysis for Concat, the exported model can do
automatic type promotion for Concat nodes, including mixed fp16 and fp32
inputs, for example.
Unit tests based on the original PR #24378