[ONNX] minor clarifications of docstrings (#69260)#69549
Closed
BowenBao wants to merge 3 commits intogh/BowenBao/175/basefrom
Closed
[ONNX] minor clarifications of docstrings (#69260)#69549BowenBao wants to merge 3 commits intogh/BowenBao/175/basefrom
BowenBao wants to merge 3 commits intogh/BowenBao/175/basefrom
Conversation
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. [ghstack-poisoned]
This was referenced Dec 7, 2021
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 7c8ff72 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Member
|
@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after pytorch#67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. ghstack-source-id: 6572ba2 Pull Request resolved: pytorch#69549
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Member
|
@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
Member
|
@msaroufim has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
[ONNX] minor clarifications of docstrings
important information and we should make users dig through source
code to find it.
Differential Revision: D32994267