[ONNX] minor clarifications of docstrings#69260
Merged
garymm merged 2 commits intopytorch:onnx_ms_1from Dec 6, 2021
Merged
Conversation
1. Make description of ONNX_ATEN_FALLBACK more accurate (after pytorch#67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it.
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 2edd53d (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
| Job | Step | Action |
|---|---|---|
| Report results | 🔁 rerun |
This comment was automatically generated by Dr. CI (expand for details).
Please report bugs/suggestions to the (internal) Dr. CI Users group.
Collaborator
Author
|
@xadupre LGTY? |
BowenBao
reviewed
Dec 1, 2021
torch/onnx/__init__.py
Outdated
| Must be ``== _onnx_main_opset or in _onnx_stable_opsets``, | ||
| defined in torch/onnx/symbolic_helper.py. | ||
| opset_version (int, default 9): The version of the | ||
| `default opset <https://github.com/onnx/onnx/blob/master/docs/Operators.md>`_ |
Collaborator
There was a problem hiding this comment.
what does default opset mean?
Collaborator
Author
There was a problem hiding this comment.
If an op doesn't specify a domain, it's in the default opset AKA ai.onnx.
I guess if it's not clear to you then it definitely won't be clear to many people.
Any suggestions as to how to write this to make it clearer?
Collaborator
There was a problem hiding this comment.
exchanging default with ai.onnx or ONNX or default (ai.onnx)?
Clarify what opset
Collaborator
Author
|
Merging. @xadupre if this is still not clear, LMK and I will be happy to make another change. |
BowenBao
added a commit
that referenced
this pull request
Dec 7, 2021
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. [ghstack-poisoned]
BowenBao
added a commit
to BowenBao/pytorch
that referenced
this pull request
Jan 5, 2022
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after pytorch#67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. ghstack-source-id: 6572ba2 Pull Request resolved: pytorch#69549
BowenBao
added a commit
that referenced
this pull request
Jan 7, 2022
…69260)" [ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 7, 2022
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 11, 2022
…69260)" [ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
BowenBao
added a commit
that referenced
this pull request
Jan 11, 2022
[ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Differential Revision: [D32994267](https://our.internmc.facebook.com/intern/diff/D32994267) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 14, 2022
Summary: Pull Request resolved: #69549 [ONNX] minor clarifications of docstrings 1. Make description of ONNX_ATEN_FALLBACK more accurate (after #67460). 2. Specify minimum and maximum values for opset_version. This is pretty important information and we should make users dig through source code to find it. Test Plan: Imported from OSS Reviewed By: malfet Differential Revision: D32994267 Pulled By: msaroufim fbshipit-source-id: ba641404107baa23506d337eca742fc1fe9f0772
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
important information and we should make users dig through source
code to find it.