[PyTorch Edge] Avoid string copying in TypeParser by swolchok · Pull Request #64278 · pytorch/pytorch

swolchok · 2021-08-31T16:03:39Z

Stack from ghstack:

Use c10::string_view and const char* to copy less.

Differential Revision: D30650712

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

facebook-github-bot · 2021-08-31T16:03:45Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/64278
📄 Preview docs built from this PR
📄 Preview C++ docs built from this PR
↩️ [fb-only] Re-run with SSH instructions
🔧 Opt-in to CIFlow to control what jobs run on your PRs

💊 CI failures summary and remediations

As of commit 6b28ff1 (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

2/2 tentatively recognized as flaky ❄️
- Click here to rerun these jobs

❄️ 2 failures tentatively classified as flaky

but reruns have not yet been triggered to confirm:

pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

Step: "Check for no AVX instruction by default" (full log | diagnosis details | 🔁 rerun) ❄️

E: Failed to fetch https://deb.nodesource.com/n...: /etc/ssl/certs/ca-certificates.crt CRLfile: none

Ign:10 https://deb.nodesource.com/node_12.x xenial/main Sources
Ign:16 https://deb.nodesource.com/node_12.x xenial/main amd64 Packages
Ign:14 https://deb.nodesource.com/node_12.x xenial/main all Packages
Err:10 https://deb.nodesource.com/node_12.x xenial/main Sources
  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
Ign:16 https://deb.nodesource.com/node_12.x xenial/main amd64 Packages
Ign:14 https://deb.nodesource.com/node_12.x xenial/main all Packages
Fetched 4466 kB in 4s (1084 kB/s)
Reading package lists...
W: The repository 'https://deb.nodesource.com/node_12.x xenial Release' does not have a Release file.
E: Failed to fetch https://deb.nodesource.com/node_12.x/dists/xenial/main/source/Sources  server certificate verification failed. CAfile: /etc/ssl/certs/ca-certificates.crt CRLfile: none
E: Some index files failed to download. They have been ignored, or old ones used instead.


Exited with code exit status 100

linux-xenial-cuda11.3-py3.6-gcc7 / test (default, 2, 2, linux.8xlarge.nvidia.gpu) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun) ❄️

2021-09-30T22:46:48.7663980Z unknown file: Failure

2021-09-30T22:46:48.7641511Z �[0;32m[       OK ] �[mNVFuserTest.FusionTVSplit_CUDA (0 ms)
2021-09-30T22:46:48.7642496Z �[0;32m[ RUN      ] �[mNVFuserTest.FusionTVMerge_CUDA
2021-09-30T22:46:48.7643511Z �[0;32m[       OK ] �[mNVFuserTest.FusionTVMerge_CUDA (0 ms)
2021-09-30T22:46:48.7644553Z �[0;32m[ RUN      ] �[mNVFuserTest.FusionTVReorder_CUDA
2021-09-30T22:46:48.7645608Z �[0;32m[       OK ] �[mNVFuserTest.FusionTVReorder_CUDA (0 ms)
2021-09-30T22:46:48.7646654Z �[0;32m[ RUN      ] �[mNVFuserTest.FusionEquality_CUDA
2021-09-30T22:46:48.7647663Z �[0;32m[       OK ] �[mNVFuserTest.FusionEquality_CUDA (0 ms)
2021-09-30T22:46:48.7648721Z �[0;32m[ RUN      ] �[mNVFuserTest.FusionDependency_CUDA
2021-09-30T22:46:48.7649825Z �[0;32m[       OK ] �[mNVFuserTest.FusionDependency_CUDA (0 ms)
2021-09-30T22:46:48.7650845Z �[0;32m[ RUN      ] �[mNVFuserTest.FusionParser_CUDA
2021-09-30T22:46:48.7663980Z unknown file: Failure
2021-09-30T22:46:48.7665628Z C++ exception with description "Couldn't find an operator for aten::_softmax_backward_data(Tensor grad_output, Tensor output, int dim, Tensor self) -> Tensor. Do you have to update a set of hardcoded JIT ops?
2021-09-30T22:46:48.7667204Z Exception raised from lookupByLiteral at /var/lib/jenkins/workspace/torch/csrc/jit/runtime/operator.cpp:141 (most recent call first):
2021-09-30T22:46:48.7669506Z frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >) + 0x6b (0x7f00f15bacbb in /opt/conda/lib/python3.6/site-packages/torch/bin/libc10.so)
2021-09-30T22:46:48.7671739Z frame #1: c10::detail::torchCheckFail(char const*, char const*, unsigned int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0xce (0x7f00f15b690e in /opt/conda/lib/python3.6/site-packages/torch/bin/libc10.so)
2021-09-30T22:46:48.7673739Z frame #2: torch::jit::getOperatorForLiteral(char const*) + 0x1a0c (0x7f00f584d16c in /opt/conda/lib/python3.6/site-packages/torch/bin/libtorch_cpu.so)
2021-09-30T22:46:48.7675295Z frame #3: <unknown function> + 0xd8156e (0x7f00e2de456e in /opt/conda/lib/python3.6/site-packages/torch/bin/libtorch_cuda_cu.so)
2021-09-30T22:46:48.7677000Z frame #4: torch::jit::fuser::cuda::parseJitIR(std::shared_ptr<torch::jit::Graph> const&) + 0x7a5 (0x7f00e2de77b5 in /opt/conda/lib/python3.6/site-packages/torch/bin/libtorch_cuda_cu.so)
2021-09-30T22:46:48.7678778Z frame #5: torch::jit::NVFuserTest_FusionParser_CUDA_Test::TestBody() + 0x531 (0x6f7b31 in /opt/conda/lib/python3.6/site-packages/torch/bin/test_jit)
2021-09-30T22:46:48.7680957Z frame #6: void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) + 0x4a (0x805b9a in /opt/conda/lib/python3.6/site-packages/torch/bin/test_jit)
2021-09-30T22:46:48.7682686Z frame #7: /opt/conda/lib/python3.6/site-packages/torch/bin/test_jit() [0x7f56a0]

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 137085045 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 137381860 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 137441338 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 137566826 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 137694628 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 138169260 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Pull Request resolved: #64278 Use c10::string_view and const char* to copy less. ghstack-source-id: 138545732 Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/)

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

pytorch-probot · 2021-09-22T23:31:09Z

CI Flow Status

⚛️ CI Flow

Ruleset - Version: v1
Ruleset - File: https://github.com/pytorch/pytorch/blob/6b28ff1916554bbf87118aac8162b03ef8cc3ec4/.github/generated-ciflow-ruleset.json
PR ciflow labels: ciflow/default

Workflows	Labels (bold enabled)	Status
Triggered Workflows
linux-bionic-py3.6-clang9	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`, `ciflow/noarch`, `ciflow/xla`	✅ triggered
linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
linux-xenial-py3.6-gcc7-bazel-test	`ciflow/all`, `ciflow/bazel`, `ciflow/cpu`, `ciflow/default`, `ciflow/linux`	✅ triggered
win-vs2019-cpu-py3	`ciflow/all`, `ciflow/cpu`, `ciflow/default`, `ciflow/win`	✅ triggered
win-vs2019-cuda11.3-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/default`, `ciflow/win`	✅ triggered
Skipped Workflows
libtorch-linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
libtorch-linux-xenial-cuda11.3-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`	🚫 skipped
linux-bionic-cuda10.2-py3.9-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
linux-xenial-cuda10.2-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/slow`	🚫 skipped
parallelnative-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped
periodic-libtorch-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/libtorch`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-linux-xenial-cuda11.1-py3.6-gcc7	`ciflow/all`, `ciflow/cuda`, `ciflow/linux`, `ciflow/scheduled`	🚫 skipped
periodic-win-vs2019-cuda11.1-py3	`ciflow/all`, `ciflow/cuda`, `ciflow/scheduled`, `ciflow/win`	🚫 skipped
puretorch-linux-xenial-py3.6-gcc5.4	`ciflow/all`, `ciflow/cpu`, `ciflow/linux`	🚫 skipped

You can add a comment to the PR and tag @pytorchbot with the following commands:

# ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun

# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slow

For more information, please take a look at the CI Flow Wiki.

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

[PyTorch Edge] Avoid string copying in TypeParser

18bfa2e

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

facebook-github-bot added oncall: jit Add this issue/PR to JIT oncall triage queue cla signed labels Aug 31, 2021

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

45206b8

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

1acd798

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

cec8b1f

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

db7c0a5

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

9e9fe42

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

403d3ff

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

2397954

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

e2197dc

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

swolchok added 2 commits September 13, 2021 15:02

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

677839f

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

56a35fd

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

swolchok added 2 commits September 16, 2021 15:55

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

15449f1

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

fd51bcf

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

swolchok mentioned this pull request Sep 20, 2021

[PyTorch] Adopt faster Tuple::create #65381

Closed

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

d9a9c38

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

swolchok added 5 commits September 21, 2021 09:51

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

a68fec1

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

96cecfc

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

b0691ce

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

6265e4b

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

98fddc2

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

pytorch-probot bot added the ciflow/default label Sep 22, 2021

swolchok added 2 commits September 23, 2021 10:46

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

826cf0b

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

399b1e5

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

This was referenced Sep 23, 2021

[PyTorch] Add IValue::toTupleRef() #65504

Closed

[PyTorch] Adopt IValue::toTupleRef() where obvious #65505

Closed

swolchok added 7 commits September 23, 2021 14:48

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

c76a693

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

30e18b0

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

8ad4206

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

35c7afe

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

be33af9

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

2ce9fda

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

Update on "[PyTorch Edge] Avoid string copying in TypeParser"

6b28ff1

Use c10::string_view and const char* to copy less. Differential Revision: [D30650712](https://our.internmc.facebook.com/intern/diff/D30650712/) [ghstack-poisoned]

facebook-github-bot closed this in 7c75875 Oct 4, 2021

facebook-github-bot deleted the gh/swolchok/285/head branch October 8, 2021 14:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PyTorch Edge] Avoid string copying in TypeParser#64278

[PyTorch Edge] Avoid string copying in TypeParser#64278
swolchok wants to merge 28 commits intogh/swolchok/285/basefrom
gh/swolchok/285/head

swolchok commented Aug 31, 2021 •

edited

Loading

Uh oh!

facebook-github-bot commented Aug 31, 2021 •

edited

Loading

Uh oh!

pytorch-probot bot commented Sep 22, 2021 •

edited

Loading

⚛️ CI Flow

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

swolchok commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Aug 31, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

💊 CI failures summary and remediations

❄️ 2 failures tentatively classified as flaky

pytorch_linux_xenial_py3_6_gcc5_4_test (1/2)

linux-xenial-cuda11.3-py3.6-gcc7 / test (default, 2, 2, linux.8xlarge.nvidia.gpu) (2/2)

Uh oh!

pytorch-probot bot commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚛️ CI Flow

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

swolchok commented Aug 31, 2021 •

edited

Loading

facebook-github-bot commented Aug 31, 2021 •

edited

Loading

pytorch-probot bot commented Sep 22, 2021 •

edited

Loading