[PyTorch] Adopt faster Tuple::create#65381
Closed
swolchok wants to merge 35 commits intogh/swolchok/323/basefrom
Closed
[PyTorch] Adopt faster Tuple::create#65381swolchok wants to merge 35 commits intogh/swolchok/323/basefrom
swolchok wants to merge 35 commits intogh/swolchok/323/basefrom
Conversation
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 1de96d1 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Sep 20, 2021
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 20, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138545813 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 21, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138621168 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 21, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138662576 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 22, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138728162 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 22, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138752931 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 22, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 138790747 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
This was referenced Sep 23, 2021
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
This was referenced Oct 5, 2021
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
…r Tuple::create" The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 12, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 140421305 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 14, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 140618344 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 15, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 140695396 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 30, 2021
Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 141993702 Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)!
The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. Differential Revision: [D31069538](https://our.internmc.facebook.com/intern/diff/D31069538/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31069538/)! [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
Summary: Pull Request resolved: #65381 The previous diff adds a way to make Tuples of size 3 or less more efficiently. This diff makes it easier to hit that path and updates a bunch of callsites to hit it. ghstack-source-id: 142065832 Test Plan: CI Reviewed By: ezyang Differential Revision: D31069538 fbshipit-source-id: d04da3709594ed68ab1c0a1471f8cffd8d001628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
The previous diff adds a way to make Tuples of size 3 or less
more efficiently. This diff makes it easier to hit that path and
updates a bunch of callsites to hit it.
Differential Revision: D31069538
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!