[PyTorch] Add IValue::toTupleRef()#65504
Closed
swolchok wants to merge 21 commits intogh/swolchok/328/basefrom
Closed
[PyTorch] Add IValue::toTupleRef()#65504swolchok wants to merge 21 commits intogh/swolchok/328/basefrom
swolchok wants to merge 21 commits intogh/swolchok/328/basefrom
Conversation
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: # ciflow rerun, "ciflow/default" will always be added automatically
@pytorchbot ciflow rerun
# ciflow rerun with additional labels "-l <ciflow/label_name>", which is equivalent to adding these labels manually and trigger the rerun
@pytorchbot ciflow rerun -l ciflow/scheduled -l ciflow/slowFor more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 35ce5f9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
swolchok
added a commit
that referenced
this pull request
Sep 23, 2021
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) ghstack-source-id: 138792846 Pull Request resolved: #65504
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
This was referenced Sep 23, 2021
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
This was referenced Oct 5, 2021
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
…:toTupleRef()" We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 18, 2021
Pull Request resolved: #65504 We should be able to borrow a Tuple from an IValue without incurring refcount bumps. ghstack-source-id: 140913605 Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/)
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
We should be able to borrow a Tuple from an IValue without incurring refcount bumps. Differential Revision: [D31130570](https://our.internmc.facebook.com/intern/diff/D31130570/) [ghstack-poisoned]
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
Summary: Pull Request resolved: #65504 We should be able to borrow a Tuple from an IValue without incurring refcount bumps. ghstack-source-id: 142065833 Test Plan: Added test coverage. Profiled static runtime on the local_ro net for ctr_mobile_feed. Inclusive time spent in VarTupleUnpack decreased about 0.3%, which roughly matches with the 0.36% of runtime that was previously spent in IValue::toTuple(). Reviewed By: hlu1 Differential Revision: D31130570 fbshipit-source-id: afa14f46445539e449068fd908d547b8da7f402c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We should be able to borrow a Tuple from an IValue without incurring refcount bumps.
Differential Revision: D31130570