[PyTorch] Adopt IValue::toTupleRef() where obvious#65505
Closed
swolchok wants to merge 21 commits intogh/swolchok/329/basefrom
Closed
[PyTorch] Adopt IValue::toTupleRef() where obvious#65505swolchok wants to merge 21 commits intogh/swolchok/329/basefrom
swolchok wants to merge 21 commits intogh/swolchok/329/basefrom
Conversation
Generated with `fastmod command 1` followed by `fastmod command 2` to unbreak 2 callsites. Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)! [ghstack-poisoned]
CI Flow Status⚛️ CI FlowRuleset - Version:
You can add a comment to the PR and tag @pytorchbot with the following commands: For more information, please take a look at the CI Flow Wiki. |
Contributor
🔗 Helpful links
💊 CI failures summary and remediationsAs of commit 6ab7eb4 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
swolchok
added a commit
that referenced
this pull request
Sep 23, 2021
Generated with `fastmod command 1` followed by `fastmod command 2` to unbreak 2 callsites. Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)! ghstack-source-id: 138794582 Pull Request resolved: #65505
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
This was referenced Sep 23, 2021
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 23, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 138888288 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 27, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 139078757 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 29, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 139344603 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 30, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 139448251 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Sep 30, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 139468092 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
ezyang
approved these changes
Oct 4, 2021
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
This was referenced Oct 5, 2021
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 6, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 139930028 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
…e::toTupleRef() where obvious"
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Oct 19, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 140983179 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
Generated with
`fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'`
, followed by
`fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'`
to unbreak 2 callsites.
Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/)
**NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
[ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Nov 1, 2021
Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 142065835 Differential Revision: [D31131025](https://our.internmc.facebook.com/intern/diff/D31131025/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D31131025/)!
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 2, 2021
Summary: Pull Request resolved: #65505 Generated with `fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.'` , followed by `fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'` to unbreak 2 callsites. ghstack-source-id: 142065835 Test Plan: CI Reviewed By: gchanan Differential Revision: D31131025 fbshipit-source-id: 54457ae5bbeb38db9c7f196d469b98521c3d3f34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Generated with
fastmod -m 'toTuple\(\)(\s*)->' 'toTupleRef()${1}.', followed by
fastmod '(std::move\(.*)toTupleRef\(\).' '${1}toTuple()->'to unbreak 2 callsites.
Differential Revision: D31131025
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!