[PyTorch] Remove always-empty string args to inferFunctionSchemaFromFunctor#51307
Closed
swolchok wants to merge 3 commits intogh/swolchok/100/basefrom
Closed
[PyTorch] Remove always-empty string args to inferFunctionSchemaFromFunctor#51307swolchok wants to merge 3 commits intogh/swolchok/100/basefrom
swolchok wants to merge 3 commits intogh/swolchok/100/basefrom
Conversation
…unctor Using -ftime-trace shows that this roughly halves time spent compile/optimizing this function in an optimized build of RegisterCPU.cpp (savings of about 1 second). Differential Revision: [D26135978](https://our.internmc.facebook.com/intern/diff/D26135978/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 3084750 (more details on the Dr. CI page):
1 failure not recognized by patterns:
1 job timed out:
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 28, 2021
This was referenced Jan 28, 2021
…SchemaFromFunctor" Using -ftime-trace shows that this roughly halves time spent compile/optimizing this function in an optimized build of RegisterCPU.cpp (savings of about 1 second). Differential Revision: [D26135978](https://our.internmc.facebook.com/intern/diff/D26135978/) [ghstack-poisoned]
ezyang
approved these changes
Jan 29, 2021
This was referenced Jan 29, 2021
…SchemaFromFunctor" Using -ftime-trace shows that this roughly halves time spent compile/optimizing this function in an optimized build of RegisterCPU.cpp (savings of about 1 second). Differential Revision: [D26135978](https://our.internmc.facebook.com/intern/diff/D26135978/) [ghstack-poisoned]
Contributor
|
This pull request has been merged in 205c971. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…unctor (pytorch#51307) Summary: Pull Request resolved: pytorch#51307 Using -ftime-trace shows that this roughly halves time spent compile/optimizing this function in an optimized build of RegisterCPU.cpp (savings of about 1 second). ghstack-source-id: 120697493 Test Plan: manual build with -ftime-trace as above; sketch of directions at https://fb.workplace.com/groups/894363187646754/permalink/1153321361750934/ , except that I extracted a compiler invocation for RegisterCPU.cpp by injecting a syntax error and running buck build with -v 3 so that I could rebuild and measure just the one file quickly. Reviewed By: ezyang Differential Revision: D26135978 fbshipit-source-id: 756499fbcc8d3b169bae5a463f63caecb79f7fcd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Using -ftime-trace shows that this roughly halves time spent compile/optimizing this function in an optimized build of RegisterCPU.cpp (savings of about 1 second).
Differential Revision: D26135978