Skip to content

[PyTorch] IWYU in torch/csrc/utils/future.h#51293

Closed
swolchok wants to merge 3 commits intogh/swolchok/98/basefrom
gh/swolchok/98/head
Closed

[PyTorch] IWYU in torch/csrc/utils/future.h#51293
swolchok wants to merge 3 commits intogh/swolchok/98/basefrom
gh/swolchok/98/head

Conversation

@swolchok
Copy link
Copy Markdown
Contributor

@swolchok swolchok commented Jan 28, 2021 •
edited
Loading

Stack from ghstack:

It looks like this header did not need ivalue.h at all.

Differential Revision: D26128288

@swolchok
[PyTorch] IWYU in torch/csrc/utils/future.h
848c2b5 
It looks like this header did not need ivalue.h at all. This seems to knock a minute off parse times in an optimized build.

Differential Revision: [D26128288](https://our.internmc.facebook.com/intern/diff/D26128288/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Jan 28, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit ff6c9ed (more details on the Dr. CI page):

  • 2/2 failures possibly* introduced in this PR
    • 1/2 non-CircleCI failure(s)

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test1 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

[ FAILED ] UtilsNMSTest.GPUEqualsCPUCorrectnessTest 
[       OK ] UtilsNMSTest.TestNMSGPURotatedAngle0 (2 ms)
[ RUN      ] UtilsNMSTest.TestPerfRotatedNMS
RotatedNMS, nproposals=2000, ntests=10, Avg GPU time = 13.909970ms, Avg CPU time = 543.418700ms, GPU speed up = 39.066849X 
[       OK ] UtilsNMSTest.TestPerfRotatedNMS (5576 ms)
[----------] 5 tests from UtilsNMSTest (20971 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test case ran. (20971 ms total)
[  PASSED  ] 4 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] UtilsNMSTest.GPUEqualsCPUCorrectnessTest

 1 FAILED TEST
"generate_proposals_op_util_nms_gpu_test" failed with exit code 1
+ cleanup
+ retcode=1
+ set +x


Exited with code exit status 1
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

This was referenced Jan 28, 2021
Closed
Closed
Closed
Closed
Closed
swolchok added a commit that referenced this pull request Jan 28, 2021
@swolchok
[PyTorch] IWYU in torch/csrc/utils/future.h
8b7dabb 
It looks like this header did not need ivalue.h at all. This seems to knock a minute off parse times in an optimized build.

Differential Revision: [D26128288](https://our.internmc.facebook.com/intern/diff/D26128288/)

ghstack-source-id: 120578107
Pull Request resolved: #51293
This was referenced Jan 28, 2021
Closed
Closed
Closed
Closed
Closed
@swolchok
Update on "[PyTorch] IWYU in torch/csrc/utils/future.h"
e175c4c 
It looks like this header did not need ivalue.h at all. This seems to knock a minute off parse times in an optimized build.

Differential Revision: [D26128288](https://our.internmc.facebook.com/intern/diff/D26128288/)

[ghstack-poisoned]
This was referenced Jan 29, 2021
Closed
Closed
@swolchok
Update on "[PyTorch] IWYU in torch/csrc/utils/future.h"
ff6c9ed 
It looks like this header did not need ivalue.h at all.

Differential Revision: [D26128288](https://our.internmc.facebook.com/intern/diff/D26128288/)

[ghstack-poisoned]
@swolchok swolchok mentioned this pull request Feb 1, 2021
Closed
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2021

This pull request has been merged in 1416fb9.

@facebook-github-bot facebook-github-bot deleted the gh/swolchok/98/head branch February 5, 2021 15:22
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@swolchok @facebook-github-bot
[PyTorch] IWYU in torch/csrc/utils/future.h (pytorch#51293)
5c8637c 
Summary:
Pull Request resolved: pytorch#51293

It looks like this header did not need ivalue.h at all.
ghstack-source-id: 120697488

Test Plan: CI to ensure correctness

Reviewed By: ezyang

Differential Revision: D26128288

fbshipit-source-id: a24a7e49b9d623fb182bdfaf286972739497e770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@osalpekar osalpekar Awaiting requested review from osalpekar

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@swolchok @facebook-github-bot @ezyang