[PyTorch] Fix return value of IValue::to for Tensor/String#51463
Closed
swolchok wants to merge 4 commits intogh/swolchok/109/basefrom
Closed
[PyTorch] Fix return value of IValue::to for Tensor/String#51463swolchok wants to merge 4 commits intogh/swolchok/109/basefrom
swolchok wants to merge 4 commits intogh/swolchok/109/basefrom
Conversation
We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. Differential Revision: [D26163848](https://our.internmc.facebook.com/intern/diff/D26163848/) [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 16f796e (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Feb 1, 2021
We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. Differential Revision: [D26163848](https://our.internmc.facebook.com/intern/diff/D26163848/) [ghstack-poisoned]
We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. Differential Revision: [D26163848](https://our.internmc.facebook.com/intern/diff/D26163848/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Feb 9, 2021
Pull Request resolved: #51463 We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. ghstack-source-id: 121298431 Differential Revision: [D26163848](https://our.internmc.facebook.com/intern/diff/D26163848/)
We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. Differential Revision: [D26163848](https://our.internmc.facebook.com/intern/diff/D26163848/) [ghstack-poisoned]
bhosmer
approved these changes
Feb 11, 2021
bhosmer
left a comment
There was a problem hiding this comment.
Nice - I was trying to come up with alternative names like ivalue_to_const_ref_if_possible etc. but I couldn't come up with a clear enough winner to make it worth another round of edits. (although if there were, we could use the same suffix on list_element_to for consistency)
Contributor
|
This pull request has been merged in b2aa63f. |
xsacha
pushed a commit
to xsacha/pytorch
that referenced
this pull request
Mar 31, 2021
…1463) Summary: Pull Request resolved: pytorch#51463 We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. ghstack-source-id: 121363468 Test Plan: CI built and ran AdIndexer benchmark w/ batch size 1 under perf stat --repeat 5 to make sure it didn't regress Reviewed By: bhosmer Differential Revision: D26163848 fbshipit-source-id: b8563263b9f9fa5311c7d7cedc89e28bc5badda0
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…1463) Summary: Pull Request resolved: pytorch#51463 We can make the return type of the `to()` template match the return type of toFoo() by using the same technique we use for `list_element_to_const_ref`. Also simplifies `list_element_to_const_ref`. ghstack-source-id: 121363468 Test Plan: CI built and ran AdIndexer benchmark w/ batch size 1 under perf stat --repeat 5 to make sure it didn't regress Reviewed By: bhosmer Differential Revision: D26163848 fbshipit-source-id: b8563263b9f9fa5311c7d7cedc89e28bc5badda0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
We can make the return type of the
to()template match the return type of toFoo() by using the same technique we use forlist_element_to_const_ref. Also simplifieslist_element_to_const_ref.Differential Revision: D26163848