[PyTorch] Outline OperatorEntry::assertSignatureIsCorrect fail path#51269
Closed
swolchok wants to merge 4 commits intogh/swolchok/97/basefrom
Closed
[PyTorch] Outline OperatorEntry::assertSignatureIsCorrect fail path#51269swolchok wants to merge 4 commits intogh/swolchok/97/basefrom
swolchok wants to merge 4 commits intogh/swolchok/97/basefrom
Conversation
This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Differential Revision: [D26121814](https://our.internmc.facebook.com/intern/diff/D26121814/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26121814/)! [ghstack-poisoned]
Contributor
💊 CI failures summary and remediationsAs of commit 1034354 (more details on the Dr. CI page):
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jan 28, 2021
…ct fail path" This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Differential Revision: [D26121814](https://our.internmc.facebook.com/intern/diff/D26121814/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26121814/)! [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jan 28, 2021
Pull Request resolved: #51269 This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Differential Revision: [D26121814](https://our.internmc.facebook.com/intern/diff/D26121814/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26121814/)! ghstack-source-id: 120554676
This was referenced Jan 28, 2021
…fail path" This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Differential Revision: [D26121814](https://our.internmc.facebook.com/intern/diff/D26121814/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26121814/)! [ghstack-poisoned]
ezyang
reviewed
Jan 29, 2021
| return str.str(); | ||
| } | ||
|
|
||
| void OperatorEntry::reportSignatureError(std::string name) const { |
Contributor
There was a problem hiding this comment.
std::string by value? (eyebrow quirk)
Contributor
Author
There was a problem hiding this comment.
It's coming from a prvalue so there's no point in trying to pass that by reference -- https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/fbcode/caffe2/aten/src/ATen/core/dispatch/CppSignature.h?commit=5d6752aa058ea0b4b2241ff90efc86d9d38c06d3&lines=28-30
ezyang
approved these changes
Jan 29, 2021
This was referenced Jan 29, 2021
…fail path" This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Differential Revision: [D26121814](https://our.internmc.facebook.com/intern/diff/D26121814/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D26121814/)! [ghstack-poisoned]
Codecov Report
@@ Coverage Diff @@
## gh/swolchok/97/base #51269 +/- ##
====================================================
Coverage 80.85% 80.85%
====================================================
Files 1938 1938
Lines 211171 211175 +4
====================================================
+ Hits 170738 170742 +4
Misses 40433 40433 |
Contributor
|
This pull request has been merged in d1ddc5d. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…ytorch#51269) Summary: Pull Request resolved: pytorch#51269 This saves about 10% of the compile time of Functions.cpp. Found using clang-9's `-ftime-trace` feature + ClangBuildAnalyzer. Test Plan: Compared -ftime-trace + ClangBuildAnalyzer output. Before: P167884397 After: P167888502 Note that time spent generating assertSignatureIsCorrect is way down, though it's still kind of slow. Reviewed By: ezyang Differential Revision: D26121814 fbshipit-source-id: 949a85d8939c02e4fb5ac1adc35905ed34414724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This saves about 10% of the compile time of Functions.cpp. Found using clang-9's
-ftime-tracefeature + ClangBuildAnalyzer.Differential Revision: D26121814
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!