shape analysis fix for default dtype'#40938
Closed
eellison wants to merge 2 commits intogh/eellison/84/basefrom
Closed
shape analysis fix for default dtype'#40938eellison wants to merge 2 commits intogh/eellison/84/basefrom
eellison wants to merge 2 commits intogh/eellison/84/basefrom
Conversation
[ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit b8dae8e (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 3 times. |
jamesr66a
approved these changes
Jul 6, 2020
already accepted in #40645 Differential Revision: [D22394675](https://our.internmc.facebook.com/intern/diff/D22394675) [ghstack-poisoned]
Contributor
csarofeen
pushed a commit
to csarofeen/pytorch
that referenced
this pull request
Jul 7, 2020
Summary: Pull Request resolved: pytorch#40938 already accepted in pytorch#40645 Test Plan: Imported from OSS Reviewed By: jamesr66a, Krovatkin Differential Revision: D22394675 Pulled By: eellison fbshipit-source-id: 1e9dbb24a4cb564d9a68280d2166329ca9fb0425
malfet
pushed a commit
that referenced
this pull request
Jul 7, 2020
* [JIT] fix unfold shape analysis (#40749) Summary: unfold on a 0-dimensioned tensor returns a 1-dim tensor Pull Request resolved: #40749 Differential Revision: D22361481 Pulled By: eellison fbshipit-source-id: 621597e5f97f6e39953eb86f8b85bb4142527a9f * shape analysis fix for default dtype' ghstack-source-id: 723aa27 Pull Request resolved: #40938 * fix grad thrashing of shape analysis ghstack-source-id: dd8742b Pull Request resolved: #40939 Co-authored-by: Elias Ellison <eellison@fb.com>
csarofeen
added a commit
to csarofeen/pytorch
that referenced
this pull request
Aug 16, 2020
This reverts commit cb9cf9e.
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#40938 already accepted in pytorch#40645 Test Plan: Imported from OSS Reviewed By: jamesr66a, Krovatkin Differential Revision: D22394675 Pulled By: eellison fbshipit-source-id: 1e9dbb24a4cb564d9a68280d2166329ca9fb0425
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
already accepted in #40645
Differential Revision: D22394675