Skip to content

[JIT] Shape analysis fix#40645

Closed
eellison wants to merge 3 commits intopytorch:release/1.6from
eellison:shape_analysis_fix
Closed

[JIT] Shape analysis fix#40645
eellison wants to merge 3 commits intopytorch:release/1.6from
eellison:shape_analysis_fix

Conversation

@eellison
Copy link
Copy Markdown
Contributor

@eellison eellison commented Jun 26, 2020

We should be using the current default dtype in shape analysis, instead of always using kDouble. This fixes an issue with aten::tensor analysis and maybe others.

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Jun 27, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 672f21b (more details on the Dr. CI page):

  • 3/3 failures introduced in this PR

🕵️ 3 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_backward_compatibility_check_test (1/3)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun)

Jun 29 20:40:49 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
Jun 29 20:40:49 processing existing schema:  __str__(__torch__.torch.classes._TorchScriptTesting._StackString _0) -> (str _0) 
Jun 29 20:40:49 processing existing schema:  __init__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jun 29 20:40:49 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int[] _0) 
Jun 29 20:40:49 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._PickleTester _0, int[] _1) -> (None _0) 
Jun 29 20:40:49 processing existing schema:  top(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jun 29 20:40:49 processing existing schema:  pop(__torch__.torch.classes._TorchScriptTesting._PickleTester _0) -> (int _0) 
Jun 29 20:40:49 processing existing schema:  get(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, Tensor _1) -> (str _0) 
Jun 29 20:40:49 processing existing schema:  __getstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0) -> (int _0) 
Jun 29 20:40:49 processing existing schema:  __setstate__(__torch__.torch.classes._TorchScriptTesting._LiteInterpreterTest _0, int _1) -> (None _0) 
Jun 29 20:40:49 processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> (None _0) 
Jun 29 20:40:49 The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not.  
Jun 29 20:40:49  
Jun 29 20:40:49 Broken ops: [ 
Jun 29 20:40:49 	quantized::embedding_bag_4bit_rowwise_offsets(Tensor weight, Tensor indices, Tensor offsets, bool scale_grad_by_freq=False, int mode=0, bool sparse=False, Tensor? per_sample_weights=None, Tensor? compressed_indices_mapping=None, bool include_last_offset=False) -> (Tensor) 
Jun 29 20:40:49 	quantized::embedding_bag_byte_rowwise_offsets(Tensor weight, Tensor indices, Tensor offsets, bool scale_grad_by_freq=False, int mode=0, bool sparse=False, Tensor? per_sample_weights=None, bool include_last_offset=False) -> (Tensor) 
Jun 29 20:40:49 	aten::_add_batch_dim(Tensor self, int batch_dim, int level) -> (Tensor) 
Jun 29 20:40:49 	aten::_remove_batch_dim(Tensor self, int level, int batch_size, int out_dim) -> (Tensor) 
Jun 29 20:40:49 ] 
Jun 29 20:40:49 + cleanup 
Jun 29 20:40:49 + retcode=1 
Jun 29 20:40:49 + set +x

See CircleCI build pytorch_xla_linux_bionic_py3_6_clang9_build (2/3)

Step: "Build" (full log | diagnosis details | 🔁 rerun)

Jun 29 20:27:02 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n return ((int*)(&strtod_l))[argc];\n ^\n1 error generated.\n" } 
Jun 29 20:27:01     assert check_overrides(overrides, overridden) 
Jun 29 20:27:01 AssertionError 
Jun 29 20:27:02 Building torch_xla version: 1.6 
Jun 29 20:27:02 XLA Commit ID: 11ecce5a1f823d4c33f0f4e01232cff0a9e0147d 
Jun 29 20:27:02 PyTorch Commit ID: 55a40bffa3d282bc5ad76e00e9714ca13e8c0f70 
Jun 29 20:27:02 Failed to generate ATEN bindings: ['/var/lib/jenkins/workspace/xla/scripts/generate_code.sh'] 
Jun 29 20:27:02 + cleanup 
Jun 29 20:27:02 + retcode=1 
Jun 29 20:27:02 + set +x 
Jun 29 20:27:02 =================== sccache compilation log =================== 
Jun 29 20:27:02 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/var/lib/jenkins/workspace/build/CMakeFiles/CMakeTmp/CheckSymbolExists.c:8:19: error: use of undeclared identifier \'strtod_l\'\n  return ((int*)(&strtod_l))[argc];\n                  ^\n1 error generated.\n" } 
Jun 29 20:27:02  
Jun 29 20:27:02 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Jun 29 20:27:02 Compile requests              5988 
Jun 29 20:27:02 Compile requests executed     3552 
Jun 29 20:27:02 Cache hits                    3536 
Jun 29 20:27:02 Cache misses                     0 
Jun 29 20:27:02 Cache timeouts                   0 
Jun 29 20:27:02 Cache read errors                0 
Jun 29 20:27:02 Forced recaches                  0 
Jun 29 20:27:02 Cache write errors               0

See CircleCI build pytorch_macos_10_13_py3_test (3/3)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

Jun 29 14:27:23 [E request_callback_impl.cpp:168] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Jun 29 14:27:23 At: 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Jun 29 14:27:23  
Jun 29 14:27:23 [E request_callback_impl.cpp:168] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Jun 29 14:27:23  
Jun 29 14:27:23 At: 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Jun 29 14:27:23  
Jun 29 14:27:23 [E request_callback_impl.cpp:168] Received error while processing request type 2: RuntimeError: Can not pickle torch.futures.Future 
Jun 29 14:27:23  
Jun 29 14:27:23 At: 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(93): serialize 
Jun 29 14:27:23   /Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/distributed/rpc/internal.py(145): serialize 
Jun 29 14:27:23  
Jun 29 14:27:23 [W tensorpipe_agent.cpp:491] RPC agent for worker1 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Jun 29 14:27:23 [W tensorpipe_agent.cpp:491] RPC agent for worker2 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown) 
Jun 29 14:27:23 [W tensorpipe_agent.cpp:491] RPC agent for worker2 encountered error when reading incoming request from worker1: EOF: end of file (this is expected to happen during shutdown) 
Jun 29 14:27:24 ok (1.583s) 
Jun 29 14:27:25   test_return_future_remote (__main__.TensorPipeAgentRpcTestWithSpawn) ... [W tensorpipe_agent.cpp:491] RPC agent for worker3 encountered error when reading incoming request from worker0: EOF: end of file (this is expected to happen during shutdown)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 14 times.

@eellison eellison mentioned this pull request Jun 29, 2020
Closed
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jun 29, 2020

Can you please reference the corresponding PR in master?

@eellison eellison mentioned this pull request Jul 2, 2020
Closed
eellison pushed a commit that referenced this pull request Jul 6, 2020
Update on "shape analysis fix for default dtype'"
b8dae8e 
already accepted in #40645

Differential Revision: [D22394675](https://our.internmc.facebook.com/intern/diff/D22394675)

[ghstack-poisoned]
facebook-github-bot pushed a commit that referenced this pull request Jul 7, 2020
@facebook-github-bot
shape analysis fix for default dtype' (#40938)
4af8424 
Summary:
Pull Request resolved: #40938

already accepted in #40645

Test Plan: Imported from OSS

Reviewed By: jamesr66a, Krovatkin

Differential Revision: D22394675

Pulled By: eellison

fbshipit-source-id: 1e9dbb24a4cb564d9a68280d2166329ca9fb0425
@eellison eellison closed this Jul 7, 2020
csarofeen pushed a commit to csarofeen/pytorch that referenced this pull request Jul 7, 2020
@csarofeen
shape analysis fix for default dtype' (pytorch#40938)
cb9cf9e 
Summary:
Pull Request resolved: pytorch#40938

already accepted in pytorch#40645

Test Plan: Imported from OSS

Reviewed By: jamesr66a, Krovatkin

Differential Revision: D22394675

Pulled By: eellison

fbshipit-source-id: 1e9dbb24a4cb564d9a68280d2166329ca9fb0425
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@facebook-github-bot
shape analysis fix for default dtype' (pytorch#40938)
77cde6d 
Summary:
Pull Request resolved: pytorch#40938

already accepted in pytorch#40645

Test Plan: Imported from OSS

Reviewed By: jamesr66a, Krovatkin

Differential Revision: D22394675

Pulled By: eellison

fbshipit-source-id: 1e9dbb24a4cb564d9a68280d2166329ca9fb0425
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZolotukhinM ZolotukhinM Awaiting requested review from ZolotukhinM

1 more reviewer

@Krovatkin Krovatkin Krovatkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eellison @malfet @Krovatkin