Bucket of shape analysis fixes#41044
Merged
malfet merged 3 commits intorelease/1.6from Jul 7, 2020
Merged
Conversation
added 3 commits
July 6, 2020 15:08
Summary: unfold on a 0-dimensioned tensor returns a 1-dim tensor Pull Request resolved: #40749 Differential Revision: D22361481 Pulled By: eellison fbshipit-source-id: 621597e5f97f6e39953eb86f8b85bb4142527a9f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picking a few PRs
[JIT] fix unfold shape analysis #40749
shape analysis fix for default dtype' #40938
fix grad thrashing of shape analysis #40939
bucketed together to make it easier to merge. They are all accepted / mergingon master. These PRs are needed to fix shape analysis to enable legacy executor for 1.6