Skip to content

[JIT] fix unfold shape analysis#40749

Closed
eellison wants to merge 1 commit intopytorch:masterfrom
eellison:fix_unfold_analysis
Closed

[JIT] fix unfold shape analysis#40749
eellison wants to merge 1 commit intopytorch:masterfrom
eellison:fix_unfold_analysis

Conversation

@eellison
Copy link
Copy Markdown
Contributor

unfold on a 0-dimensioned tensor returns a 1-dim tensor

@eellison eellison requested a review from apaszke as a code owner June 29, 2020 23:43
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 29, 2020
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@eellison merged this pull request in e1428cf.

eellison pushed a commit that referenced this pull request Jul 6, 2020
Summary:
unfold on a 0-dimensioned tensor returns a 1-dim tensor
Pull Request resolved: #40749

Differential Revision: D22361481

Pulled By: eellison

fbshipit-source-id: 621597e5f97f6e39953eb86f8b85bb4142527a9f
malfet pushed a commit that referenced this pull request Jul 7, 2020
* [JIT] fix unfold shape analysis (#40749)

Summary:
unfold on a 0-dimensioned tensor returns a 1-dim tensor
Pull Request resolved: #40749

Differential Revision: D22361481

Pulled By: eellison

fbshipit-source-id: 621597e5f97f6e39953eb86f8b85bb4142527a9f

* shape analysis fix for default dtype'

ghstack-source-id: 723aa27
Pull Request resolved: #40938

* fix grad thrashing of shape analysis

ghstack-source-id: dd8742b
Pull Request resolved: #40939

Co-authored-by: Elias Ellison <eellison@fb.com>
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
unfold on a 0-dimensioned tensor returns a 1-dim tensor
Pull Request resolved: pytorch#40749

Differential Revision: D22361481

Pulled By: eellison

fbshipit-source-id: 621597e5f97f6e39953eb86f8b85bb4142527a9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants