[quant][graphmode] Move elu to general value ops map#38165
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/308/basefrom
Closed
[quant][graphmode] Move elu to general value ops map#38165jerryzh168 wants to merge 8 commits intogh/jerryzh168/308/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/308/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 8, 2020
💊 CI failures summary and remediationsAs of commit 445e1cf (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
❄️ 1 failure tentatively classified as flakybut reruns have not yet been triggered to confirm:
|
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
| return (%r) )"; | ||
|
|
||
| // aten::elu | ||
| std::string elu = R"( |
Contributor
There was a problem hiding this comment.
Can we make this more compact? If you define a get_prefix_string_fn(aten_op) you could have a function that does:
std::string generate_op_prefix(std::string aten_op)
{
return sprintf("graph(\%a_quant, \%scale,\ %input_scale):
\%a_dequant = aten::dequantize(\%a_quant)
\%r = %s(\%a_dequant, \%scale, \%input_scale\n)",aten_op);
}
Contributor
Author
There was a problem hiding this comment.
sure, will refactor in future PR
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 11, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 12, 2020
vkuzo
approved these changes
May 12, 2020
Contributor
vkuzo
left a comment
There was a problem hiding this comment.
stamping per @jerryzh168 's request
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 13, 2020
Contributor
|
This pull request has been merged in 1669618. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38165 Test Plan: Imported from OSS Differential Revision: D21559812 fbshipit-source-id: 55bc28d71d0b8a1c33e05bce20a802db1015ea0b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21559812