Skip to content

[quant][graphmode] Support ops with fixed quantization parameters#38278

Closed
jerryzh168 wants to merge 9 commits intogh/jerryzh168/312/basefrom
gh/jerryzh168/312/head
Closed

[quant][graphmode] Support ops with fixed quantization parameters#38278
jerryzh168 wants to merge 9 commits intogh/jerryzh168/312/basefrom
gh/jerryzh168/312/head

Conversation

@jerryzh168
Copy link
Copy Markdown
Contributor

@jerryzh168 jerryzh168 commented May 11, 2020 •
edited
Loading

Stack from ghstack:

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:

  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;

Ops supported:

  • hardsigmoid
  • sigmoid
  • tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D21559811

@jerryzh168
[quant][graphmode] Support ops with fixed quantization parameters
54003bd 
Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 requested a review from apaszke as a code owner May 11, 2020 22:17
This was referenced May 11, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
jerryzh168 added a commit that referenced this pull request May 11, 2020
@jerryzh168
[quant][graphmode] Support ops with fixed quantization parameters
cd38327 
Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 73fb20e
Pull Request resolved: #38278
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label May 11, 2020
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented May 11, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 3587871 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 35 times.

@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
f455bc6 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
cecf64a 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
0bed73f 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
jerryzh168 added a commit that referenced this pull request May 12, 2020
@jerryzh168
[quant][graphmode] Support ops with fixed quantization parameters
e3455f9 
Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6c0d47e
Pull Request resolved: #38278
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
a304f4e 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@jerryzh168 jerryzh168 mentioned this pull request May 12, 2020
Closed
jerryzh168 added a commit that referenced this pull request May 12, 2020
@jerryzh168
[quant][graphmode] Support ops with fixed quantization parameters
6869b7a 
Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6c0d47e
Pull Request resolved: #38278
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
766b6eb 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced May 12, 2020
Closed
Closed
vkuzo
vkuzo reviewed May 12, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/quantization/helper.cpp
vkuzo
vkuzo reviewed May 12, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/quantization/helper.cpp Outdated
vkuzo
vkuzo reviewed May 12, 2020
View reviewed changes
Comment thread torch/csrc/jit/passes/quantization/quantization_patterns.h

// IR pattern common to all ops with fixed quantization parameters for
// asymetric quantization
std::string asym_fixed_qparam_op_suffix = R"(
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we also add some comments on the magic numbers here, even if we can't pull them out into constants?

@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
1ba0104 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
This was referenced May 13, 2020
Closed
Closed
Closed
jerryzh168 added 2 commits May 14, 2020 10:36
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
ac48678 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21559811](https://our.internmc.facebook.com/intern/diff/D21559811)

[ghstack-poisoned]
@jerryzh168
Update on "[quant][graphmode] Support ops with fixed quantization par…
3587871 
…ameters"

Summary:
Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D21559811](https://our.internmc.facebook.com/intern/diff/D21559811)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 15, 2020

This pull request has been merged in 504637a.

@facebook-github-bot facebook-github-bot deleted the gh/jerryzh168/312/head branch May 18, 2020 14:16
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@jerryzh168 @facebook-github-bot
[quant][graphmode] Support ops with fixed quantization parameters (py…
883dc80 
…torch#38278)

Summary:
Pull Request resolved: pytorch#38278

Support ops like aten::hardsigmoid that has a fixed quantization parameters:
```
  constexpr float o_scale = 1.0f / 256.0f;
  constexpr int32_t o_zero_point = 0;
```

Ops supported:
- hardsigmoid
- sigmoid
- tanh

Test Plan: Imported from OSS

Differential Revision: D21559811

fbshipit-source-id: 26f3c9c3389dea4f07b350172e2974fac8c5c470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkuzo vkuzo vkuzo approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzh168 @facebook-github-bot @vkuzo @mruberry