[quant] Remove get_qparams in Observers#38435
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/317/basefrom
Closed
[quant] Remove get_qparams in Observers#38435jerryzh168 wants to merge 8 commits intogh/jerryzh168/317/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/317/basefrom
Conversation
[ghstack-poisoned]
This was referenced May 13, 2020
This was referenced May 13, 2020
💊 CI failures summary and remediationsAs of commit c48132e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 37 times. |
[ghstack-poisoned]
[ghstack-poisoned]
supriyar
reviewed
May 15, 2020
| @@ -592,11 +580,6 @@ def _forward(self, x_orig): | |||
| def calculate_qparams(self): | |||
Contributor
There was a problem hiding this comment.
Do you need to call torch.jit.export on this method now?
Contributor
Author
There was a problem hiding this comment.
yeah, I think so, will add it
[ghstack-poisoned]
[ghstack-poisoned]
supriyar
approved these changes
May 15, 2020
Differential Revision: [D21597835](https://our.internmc.facebook.com/intern/diff/D21597835) [ghstack-poisoned]
Differential Revision: [D21597835](https://our.internmc.facebook.com/intern/diff/D21597835) [ghstack-poisoned]
Differential Revision: [D21597835](https://our.internmc.facebook.com/intern/diff/D21597835) [ghstack-poisoned]
Contributor
|
@jerryzh168 merged this pull request in 86397f6. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38435 Test Plan: Imported from OSS Differential Revision: D21597835 Pulled By: jerryzh168 fbshipit-source-id: 88a8dd110db5586509bf98fa6712290f1756c272
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
aten::cat#38570 [quant][graphmode] Different rule for handlingaten::catDifferential Revision: D21597835