[quant][graphmode] Different rule for add/add_/mul/mul_#38667
Closed
jerryzh168 wants to merge 7 commits intogh/jerryzh168/321/basefrom
Closed
[quant][graphmode] Different rule for add/add_/mul/mul_#38667jerryzh168 wants to merge 7 commits intogh/jerryzh168/321/basefrom
jerryzh168 wants to merge 7 commits intogh/jerryzh168/321/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 18, 2020
💊 CI failures summary and remediationsAs of commit 5d11776 (more details on the Dr. CI page):
Extra GitHub checks: 1 failed
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 40 times. |
| " with instruction set support avx2 or newer.") | ||
| def test_quantized_add(self): | ||
| class Add(torch.nn.Module): | ||
| class QuantizedAdd(torch.nn.Module): |
Contributor
There was a problem hiding this comment.
For brevity, you could reuse all the tests for add for mul, if you make the operator itself a parameter when you define the model.
Contributor
Author
There was a problem hiding this comment.
that would be ideal if we can do that... I don't know if it will work with torchscript if we make operator as an argument, but we may have a refactor later
raghuramank100
approved these changes
May 19, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21633555](https://our.internmc.facebook.com/intern/diff/D21633555) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21633555](https://our.internmc.facebook.com/intern/diff/D21633555) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21633555](https://our.internmc.facebook.com/intern/diff/D21633555) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21633555](https://our.internmc.facebook.com/intern/diff/D21633555) [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D21633555](https://our.internmc.facebook.com/intern/diff/D21633555) [ghstack-poisoned]
jerryzh168
commented
May 20, 2020
| "__ixor__", | ||
| "__str__", | ||
| "__len__", | ||
| static constexpr const char* magic_method_names[] = { |
Contributor
|
This pull request has been merged in a8d8fc5. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38667 Test Plan: Imported from OSS Differential Revision: D21633555 fbshipit-source-id: 03b0298e83bf4dbda41b048c0edc7bb92cd4e1df
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21633555