[quant][graphmode] Move clamp to general value ops map#38163
Closed
jerryzh168 wants to merge 8 commits intogh/jerryzh168/306/basefrom
Closed
[quant][graphmode] Move clamp to general value ops map#38163jerryzh168 wants to merge 8 commits intogh/jerryzh168/306/basefrom
jerryzh168 wants to merge 8 commits intogh/jerryzh168/306/basefrom
Conversation
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 8, 2020
💊 CI failures summary and remediationsAs of commit 3778334 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 19 times. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
| %r = aten::upsample_trilinear3d(%a_quant, %size, %align_corners, %scales_d, %scales_h, %scales_w) | ||
| return (%r) )"; | ||
|
|
||
| // aten::clamp |
Contributor
There was a problem hiding this comment.
For these types of ops, how are the scale and zero-point set in IR? Since we do not observe the outputs, how is this determined?
Contributor
Author
There was a problem hiding this comment.
we inherit the scale/zero_point from the previous quantized tensor, the code is in the first PR in the stack
Contributor
Author
There was a problem hiding this comment.
oh, actually, the code is already landed in the master
Contributor
Author
There was a problem hiding this comment.
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 11, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
supriyar
approved these changes
May 12, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 12, 2020
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced May 13, 2020
Contributor
|
This pull request has been merged in 1fde373. |
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#38163 Test Plan: Imported from OSS Differential Revision: D21559805 fbshipit-source-id: db02bd17fbc6d1335fe021265955d02d52d139e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D21559805