Skip to content

Cpython test refactor fixes#174415

Closed
trichmo wants to merge 9 commits intopytorch:mainfrom
trichmo:cpython_test_refactor_fixes
Closed

Cpython test refactor fixes#174415
trichmo wants to merge 9 commits intopytorch:mainfrom
trichmo:cpython_test_refactor_fixes

Conversation

@trichmo
Copy link
Copy Markdown
Contributor

@trichmo trichmo commented Feb 5, 2026

Resolves some xfails that made it in without dynamo ci test.
Fixes repr logic that passed dynamo ci before merge. Fixing similar root issue found in this PR

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174415

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 1 Awaiting Approval, 3 Unrelated Failures

As of commit 5251a45 with merge base c24b6a2 (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 5, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@trichmo
Copy link
Copy Markdown
Contributor Author

trichmo commented Feb 5, 2026

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Feb 5, 2026
@guilhermeleobas
Copy link
Copy Markdown
Collaborator

Hope we can catch these earlier on with #174415

@trichmo
Copy link
Copy Markdown
Contributor Author

trichmo commented Feb 5, 2026

Hope we can catch these earlier on with #174415

@guilhermeleobas Was this meant to be a different pr/issue link? Curious if there's a new workflow to track

@guilhermeleobas
Copy link
Copy Markdown
Collaborator

Oops, wrong link. The correct one is #174414

@trichmo
Copy link
Copy Markdown
Contributor Author

trichmo commented Feb 6, 2026

@guilhermeleobas does this need the ciflow/dynamo label before merging? Looks like the automation pr you linked is still open.

@guilhermeleobas guilhermeleobas added the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 6, 2026
@guilhermeleobas
Copy link
Copy Markdown
Collaborator

Yes! Just added. Feel free to merge it once it passes.

@pytorch-bot pytorch-bot Bot removed the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 9, 2026
@trichmo
Copy link
Copy Markdown
Contributor Author

trichmo commented Feb 10, 2026

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased cpython_test_refactor_fixes onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout cpython_test_refactor_fixes && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the cpython_test_refactor_fixes branch from 79bfb2a to 40c3d4f Compare February 10, 2026 13:39
@guilhermeleobas guilhermeleobas added the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 10, 2026
@pytorch-bot pytorch-bot Bot removed the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 11, 2026
@guilhermeleobas guilhermeleobas added the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 11, 2026
@pytorch-bot pytorch-bot Bot removed the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 12, 2026
@guilhermeleobas guilhermeleobas added the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Feb 12, 2026
@trichmo
Copy link
Copy Markdown
Contributor Author

trichmo commented Feb 13, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@weifengpy
Copy link
Copy Markdown
Contributor

update unit test as well? otherwise CI fails

[pull / dynamo-cpython-test / test (dynamo_cpython, 1, 1, linux.c7i.2xlarge)](https://hud.pytorch.org/pr/pytorch/pytorch/172385#63618422752) ([gh](https://github.com/pytorch/pytorch/actions/runs/22016184763/job/63618422752))
test/dynamo/cpython/3_13/test_dict.py::DictTest::test_items

● That's the one. PR #174415 — "Cpython test refactor fixes" by @trichmo (Turner Richmond), merged Feb 13, 2026.

  The PR description says it "Resolves some xfails that made it in without dynamo ci test" and fixes dict repr logic. 
  It modifies torch/_dynamo/variables/dicts.py and torch/_dynamo/variables/lists.py, which fixed DictTest.test_items.
  However, PR #174414 (which added the CPython313-test_dict-DictTest.test_items xfail marker) also landed on Feb 13,  
  and the marker wasn't removed — the two PRs likely landed in the wrong order or without coordination, leaving the 
  stale xfail marker behind.

@guilhermeleobas
Copy link
Copy Markdown
Collaborator

guilhermeleobas commented Feb 16, 2026

update unit test as well? otherwise CI fails

[pull / dynamo-cpython-test / test (dynamo_cpython, 1, 1, linux.c7i.2xlarge)](https://hud.pytorch.org/pr/pytorch/pytorch/172385#63618422752) ([gh](https://github.com/pytorch/pytorch/actions/runs/22016184763/job/63618422752))
test/dynamo/cpython/3_13/test_dict.py::DictTest::test_items

● That's the one. PR #174415 — "Cpython test refactor fixes" by @trichmo (Turner Richmond), merged Feb 13, 2026.

  The PR description says it "Resolves some xfails that made it in without dynamo ci test" and fixes dict repr logic. 
  It modifies torch/_dynamo/variables/dicts.py and torch/_dynamo/variables/lists.py, which fixed DictTest.test_items.
  However, PR #174414 (which added the CPython313-test_dict-DictTest.test_items xfail marker) also landed on Feb 13,  
  and the marker wasn't removed — the two PRs likely landed in the wrong order or without coordination, leaving the 
  stale xfail marker behind.

I think this was fixed in #175034. If not, I can address this issue first thing tomorrow morning.

edit: HUD shows this job is green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants