Remove stale dynamo cpython expected failure markers for DictTest#175034
Closed
seemethere wants to merge 1 commit intogh/seemethere/123/basefrom
Closed
Remove stale dynamo cpython expected failure markers for DictTest#175034seemethere wants to merge 1 commit intogh/seemethere/123/basefrom
seemethere wants to merge 1 commit intogh/seemethere/123/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175034
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a7b1b53 with merge base cfc49c4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
Starting merge as part of PR stack under #175035 |
mlazos
approved these changes
Feb 14, 2026
Collaborator
|
Starting merge as part of PR stack under #175035 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 14, 2026
setuptools 82 removed `pkg_resources`, which breaks `visdom` (last updated 2022) during the torchbench docker image build. This causes CycleGAN model setup to fail silently (due to `--continue_on_fail`), leading to `eager_fail_to_run` accuracy failures across all inductor torchbench CI jobs since Feb 10. Authored with Claude. Pull Request resolved: #175035 Approved by: https://github.com/weifengpy, https://github.com/oulgen, https://github.com/mlazos ghstack dependencies: #175034
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 15, 2026
…_keys (#175040) Same issue as #175034 - test_keys passes under dynamo on Python 3.13 but has a stale expected failure marker causing "unexpected success" CI failures. Pull Request resolved: #175040 Approved by: https://github.com/anijain2305
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
The `dynamo-cpython-test` CI job (added in #174414) shipped with expected failure markers for `DictTest.test_values` and `DictTest.test_items`, but these tests actually pass under dynamo on Python 3.13. The test framework treats this as "unexpected success" and reports a CI failure. Authored with Claude. ghstack-source-id: 55724ae Pull-Request: pytorch/pytorch#175034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The
dynamo-cpython-testCI job (added in #174414) shipped withexpected failure markers for
DictTest.test_valuesandDictTest.test_items, but these tests actually pass under dynamo onPython 3.13. The test framework treats this as "unexpected success"
and reports a CI failure.
Authored with Claude.