Skip to content

Add CI job to run CPython tests#174414

Closed
guilhermeleobas wants to merge 10 commits intogh/guilhermeleobas/286/basefrom
gh/guilhermeleobas/286/head
Closed

Add CI job to run CPython tests#174414
guilhermeleobas wants to merge 10 commits intogh/guilhermeleobas/286/basefrom
gh/guilhermeleobas/286/head

Conversation

@guilhermeleobas
Copy link
Copy Markdown
Collaborator

@guilhermeleobas guilhermeleobas commented Feb 5, 2026

Stack from ghstack (oldest at bottom):

The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Feb 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174414

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit fd1a89a with merge base 659af3c (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: releng release notes category label Feb 5, 2026
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
ghstack-source-id: a71119b
Pull-Request: #174414
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a CI job that only runs the CPython tests on Python 3.13 to
ensure we catch these errors earlier on.

ghstack-source-id: 8d53b96
Pull-Request: #174414
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

ghstack-source-id: 8d53b96
Pull-Request: #174414
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

ghstack-source-id: 9e4183b
Pull-Request: #174414
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

ghstack-source-id: 4b1e42d
Pull-Request: #174414
@guilhermeleobas guilhermeleobas marked this pull request as ready for review February 5, 2026 20:52
@guilhermeleobas guilhermeleobas requested a review from a team as a code owner February 5, 2026 20:52
[ghstack-poisoned]
@guilhermeleobas guilhermeleobas requested review from atalman and removed request for malfet February 5, 2026 20:57
guilhermeleobas added a commit that referenced this pull request Feb 5, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

ghstack-source-id: 6ecd6a3
Pull-Request: #174414
@Lucaskabela
Copy link
Copy Markdown
Contributor

This has my endorsement, but since it is CI related I will let devinfra folks approve (cc @atalman @seemethere)

Comment thread .github/workflows/cpython-tests.yml Outdated
name: cpython-unittest

on:
pull_request:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having pull_request trigger here would mean this new workflow will be run on all PyTorch PR, so I suggest we move it to pull.yml instead. That's where we expect all pull jobs to be.

  1. This workflow only uses CPU runner linux.c7i.2xlarge, so capacity is not an issue from infra side
  2. The test is still failing on CI though

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @huydhn. Is there a way to only trigger this job if one changes any code on torch/_dynamo?

[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 6, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

ghstack-source-id: 3db6709
Pull-Request: #174414
@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

@pytorchbot rebase

@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge -i

@seemethere
Copy link
Copy Markdown
Member

@pytorchbot revert -c nosignal -m "Looks like this is failing since it's been merged into main, https://hud.pytorch.org/pytorch/pytorch/commit/391682ea327c3ead03c23d254ee67575a24cf2f2"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Feb 13, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@guilhermeleobas your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Feb 13, 2026
@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Successfully rebased gh/guilhermeleobas/286/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/174414)

pytorchmergebot pushed a commit that referenced this pull request Feb 13, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

ghstack-source-id: 67f43f6
Pull-Request: #174414
[ghstack-poisoned]
guilhermeleobas added a commit that referenced this pull request Feb 13, 2026
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.

This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.

Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.

ghstack-source-id: ec908f9
Pull-Request: #174414
@guilhermeleobas
Copy link
Copy Markdown
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Feb 14, 2026
…75034)

The `dynamo-cpython-test` CI job (added in #174414) shipped with
expected failure markers for `DictTest.test_values` and
`DictTest.test_items`, but these tests actually pass under dynamo on
Python 3.13. The test framework treats this as "unexpected success"
and reports a CI failure.

Authored with Claude.
Pull Request resolved: #175034
Approved by: https://github.com/mlazos
@github-actions github-actions Bot deleted the gh/guilhermeleobas/286/head branch March 16, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo open source release notes: releng release notes category Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants