Add CI job to run CPython tests#174414
Add CI job to run CPython tests#174414guilhermeleobas wants to merge 10 commits intogh/guilhermeleobas/286/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174414
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit fd1a89a with merge base 659af3c ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a CI job that only runs the CPython tests on Python 3.13 to ensure we catch these errors earlier on. ghstack-source-id: 8d53b96 Pull-Request: #174414
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. ghstack-source-id: 8d53b96 Pull-Request: #174414
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. ghstack-source-id: 9e4183b Pull-Request: #174414
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 4b1e42d Pull-Request: #174414
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 6ecd6a3 Pull-Request: #174414
|
This has my endorsement, but since it is CI related I will let devinfra folks approve (cc @atalman @seemethere) |
| name: cpython-unittest | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Having pull_request trigger here would mean this new workflow will be run on all PyTorch PR, so I suggest we move it to pull.yml instead. That's where we expect all pull jobs to be.
- This workflow only uses CPU runner
linux.c7i.2xlarge, so capacity is not an issue from infra side - The test is still failing on CI though
There was a problem hiding this comment.
Thanks for the review @huydhn. Is there a way to only trigger this job if one changes any code on torch/_dynamo?
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 3db6709 Pull-Request: #174414
|
@pytorchbot rebase |
|
@pytorchbot merge -i |
|
@pytorchbot revert -c nosignal -m "Looks like this is failing since it's been merged into main, https://hud.pytorch.org/pytorch/pytorch/commit/391682ea327c3ead03c23d254ee67575a24cf2f2" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 391682e. Reverted #174414 on behalf of https://github.com/seemethere due to Looks like this is failing since it's been merged into main, https://hud.pytorch.org/pytorch/pytorch/commit/391682ea327c3ead03c23d254ee67575a24cf2f2 ([comment](#174414 (comment)))
|
@guilhermeleobas your PR has been successfully reverted. |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 67f43f6 Pull-Request: #174414
The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: ec908f9 Pull-Request: #174414
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…75034) The `dynamo-cpython-test` CI job (added in #174414) shipped with expected failure markers for `DictTest.test_values` and `DictTest.test_items`, but these tests actually pass under dynamo on Python 3.13. The test framework treats this as "unexpected success" and reports a CI failure. Authored with Claude. Pull Request resolved: #175034 Approved by: https://github.com/mlazos
Stack from ghstack (oldest at bottom):
The dynamo-unnitest (Python 3.13) job is constantly failing due to some
CPython tests starts passing or failing. In the past, I've send PRs
(#174091, #172448) to make the job green again but it is a matter of days
for it to start failing again.
This PR adds a dedicated Ci job that runs only the CPython tests on
Python 3.13, allowing us to catch these issues earlier.
Contrary to this one, the dynamo-unittest job runs weekly on a broader
set of tests. This one is supposed to run on pull requests that touches
dynamo.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo