Fix CPython 3.13 test failures reported in dynamo-unittest job by guilhermeleobas · Pull Request #172448 · pytorch/pytorch

guilhermeleobas · 2026-01-14T14:13:32Z

Stack from ghstack (oldest at bottom):

-> Fix CPython 3.13 test failures reported in dynamo-unittest job #172448

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

[ghstack-poisoned]

pytorch-bot · 2026-01-14T14:13:36Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172448

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 Cancelled Jobs

As of commit 934c564 with merge base 6cf834b ():

CANCELLED JOBS - The following jobs were cancelled. Please retry:

trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (default, 3, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (default, 5, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx942.4) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (distributed, 2, 3, linux.rocm.gpu.gfx942.4) (gh)
##[error]The operation was canceled.
trunk / linux-jammy-rocm-py3.10 / test (distributed, 3, 3, linux.rocm.gpu.gfx942.4) (gh)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: f7045c0 Pull-Request: #172448

[ghstack-poisoned]

ghstack-source-id: 5ecf602 Pull-Request: #172448

[ghstack-poisoned]

ghstack-source-id: 774b7b2 Pull-Request: #172448

[ghstack-poisoned]

ghstack-source-id: 45aaf0e Pull-Request: #172448

Lucaskabela · 2026-01-14T19:23:25Z

        finally:
            _converting.discard(self_id)

+    def is_python_constant(self):


nit: add -> bool: to function def and should be good

Lucaskabela

Minor typing nit (pyrefly signal is blocking). Should be a straightforward fix - thanks for fixing these tests!

[ghstack-poisoned]

ghstack-source-id: 75209ca Pull-Request: #172448

[ghstack-poisoned]

ghstack-source-id: b6bb216 Pull-Request: #172448

guilhermeleobas · 2026-01-14T22:28:02Z

+    def is_python_constant(self) -> bool:
+        try:
+            self.as_python_constant()
+            return True
+        except Exception:
+            return False
+


@tugsbayasgalan could you see if this change makes sense to you? _get_function() is called from as_python_constant() and if tx.output.side_effects.load_cell(cell_var) raises unsupported, Dynamo bail and skips all remaining frames. This is problematic for the CPython test suite as some tests will suddenly pass.

Quick reminder that this changes the default impl. of is_python_constant to capture any Exception and not just NotImplementedError.

Do we just need to catch ClosureConversionError as well?

~~Yes!~~ No, Unsupported.

[ghstack-poisoned]

ghstack-source-id: 4e2f5e7 Pull-Request: #172448

guilhermeleobas · 2026-01-19T21:18:35Z

@pytorchbot merge

pytorchmergebot · 2026-01-20T21:28:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-01-20T21:29:16Z

Merge failed

Reason: 9 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx942.4), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1)

Details for Dev Infra team

Raised by workflow job

guilhermeleobas · 2026-01-20T21:44:28Z

@pytorchbot merge

pytorchmergebot · 2026-01-20T21:46:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-01-20T21:46:49Z

Merge failed

Reason: 9 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 4, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 3, linux.rocm.gpu.gfx942.4), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1)

Details for Dev Infra team

Raised by workflow job

guilhermeleobas · 2026-01-20T21:49:03Z

@pytorchbot merge -i

pytorchmergebot · 2026-01-20T21:51:06Z

Merge started

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a CI job that only runs the CPython tests on Python 3.13 to ensure we catch these errors earlier on. ghstack-source-id: 8d53b96 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. ghstack-source-id: 8d53b96 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. ghstack-source-id: 9e4183b Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 4b1e42d Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 6ecd6a3 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 3db6709 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 1c3b41d Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 6915a1e Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. Pull Request resolved: #174414 Approved by: https://github.com/huydhn

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: 67f43f6 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. ghstack-source-id: ec908f9 Pull-Request: #174414

The dynamo-unnitest (Python 3.13) job is constantly failing due to some CPython tests starts passing or failing. In the past, I've send PRs (#174091, #172448) to make the job green again but it is a matter of days for it to start failing again. This PR adds a dedicated Ci job that runs only the CPython tests on Python 3.13, allowing us to catch these issues earlier. Contrary to this one, the dynamo-unittest job runs weekly on a broader set of tests. This one is supposed to run on pull requests that touches dynamo. Pull Request resolved: #174414 Approved by: https://github.com/huydhn

Update

a2d0555

[ghstack-poisoned]

pytorch-bot Bot added ciflow/inductor module: dynamo labels Jan 14, 2026

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

d846094

ghstack-source-id: f7045c0 Pull-Request: #172448

pytorchbot added the open source label Jan 14, 2026

guilhermeleobas added the ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests label Jan 14, 2026

Update

91717a7

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

82b2702

ghstack-source-id: 5ecf602 Pull-Request: #172448

guilhermeleobas added the topic: not user facing topic category label Jan 14, 2026

Update

fc11b5d

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

8dc7c07

ghstack-source-id: 774b7b2 Pull-Request: #172448

guilhermeleobas requested review from Lucaskabela and tugsbayasgalan January 14, 2026 17:36

guilhermeleobas marked this pull request as ready for review January 14, 2026 17:36

Update

f386824

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

f133668

ghstack-source-id: 45aaf0e Pull-Request: #172448

Lucaskabela reviewed Jan 14, 2026

View reviewed changes

Lucaskabela approved these changes Jan 14, 2026

View reviewed changes

Update

daeb39a

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

3cdad23

ghstack-source-id: 75209ca Pull-Request: #172448

Update

5a5c822

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 14, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

578d329

ghstack-source-id: b6bb216 Pull-Request: #172448

guilhermeleobas commented Jan 14, 2026

View reviewed changes

guilhermeleobas requested a review from williamwen42 January 16, 2026 01:32

Update

c046ba3

[ghstack-poisoned]

guilhermeleobas added a commit that referenced this pull request Jan 19, 2026

Fix CPython 3.13 test failures reported in dynamo-unittest job

85339b6

ghstack-source-id: 4e2f5e7 Pull-Request: #172448

williamwen42 approved these changes Jan 19, 2026

View reviewed changes

pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 19, 2026

pytorchmergebot added the merging label Jan 20, 2026

pytorchmergebot removed the merging label Jan 20, 2026

pytorchmergebot added the merging label Jan 20, 2026

pytorchmergebot removed the merging label Jan 20, 2026

pytorchmergebot added the merging label Jan 20, 2026

pytorchmergebot closed this in 330ef4a Jan 20, 2026

pytorchmergebot added Merged and removed merging labels Jan 20, 2026

guilhermeleobas mentioned this pull request Feb 5, 2026

Add CI job to run CPython tests #174414

Closed

github-actions Bot deleted the gh/guilhermeleobas/276/head branch February 20, 2026 02:22

Conversation

guilhermeleobas commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172448

❌ 9 Cancelled Jobs

Uh oh!

Lucaskabela Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

williamwen42 Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Jan 19, 2026

Uh oh!

pytorchmergebot commented Jan 20, 2026

Merge started

Uh oh!

pytorchmergebot commented Jan 20, 2026

Merge failed

Uh oh!

guilhermeleobas commented Jan 20, 2026

Uh oh!

pytorchmergebot commented Jan 20, 2026

Merge started

Uh oh!

pytorchmergebot commented Jan 20, 2026

Merge failed

Uh oh!

guilhermeleobas commented Jan 20, 2026

Uh oh!

pytorchmergebot commented Jan 20, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guilhermeleobas commented Jan 14, 2026 •

edited

Loading

pytorch-bot Bot commented Jan 14, 2026 •

edited

Loading

guilhermeleobas Jan 19, 2026 •

edited

Loading