🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174210

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

⚠️ 1 Awaiting Approval

As of commit 375aab8 with merge base eeb72da ():

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorchbot label "topic: not user facing"

@Lucaskabela I'm not super familiar with the CI, but does it run all the tests each commit? I am not aware of the failing test on HUD, but I've added a simple repro below which effectively does the same. It is failing for me locally on viable/strict. For simplicity links to HUD of the ghstack pr of interest and gh stack pr tested

The commit I believe caused the regression is here
The representation of range as a list [start, stop, index] is what causes the issue here - rangevariable just needs its own implementation.

import torch

@torch.compile(backend="eager", fullgraph=True)
def test_range_index():
    return range(3).index(1)

# Expected: 1 (value 1 is at position 1 in [0, 1, 2])
# Actual with bug: 2 (because it's computing [0, 3, 1].index(1))
result = test_range_index()
print(f"range(3).index(1) = {result}")
assert result == 1, f"Expected 1, got {result}"

I'm not super familiar with the CI, but does it run all the tests each commit? I am not aware of the failing test on HUD

For the CPython tests, one need to trigger the text exec by adding the label ciflow/dynamo.

Great thanks for adding the tag - think the CI is telling us there are a few failing test we can update to be passing - let's do this then reping :)

@Lucaskabela I think @guilhermeleobas has already tackled these unrelated failures (unexpected success).
See his PR
Let me know if you'd like me to wait for his changes to hit viable/strict - I can rebase and rerun the tests if so.

The failures are showing as the files he removed from the dynamo xfails:

1. FAILED [0.0894s] dynamo/cpython/3_13/test_userlist.py::UserListTest::test_subscript - RuntimeError: Unexpected success, please remove test/dynamo_expected_failures/CPython313-test_userlist-UserListTest.test_subscript

2. FAILED [17.5689s] dynamo/cpython/3_13/test_collections.py::TestCollectionABCs::test_Sequence_mixins - RuntimeError: Unexpected success, please remove test/dynamo_expected_failures/CPython313-test_collections-TestCollectionABCs.test_Sequence_mixins

3. FAILED [0.1170s] dynamo/cpython/3_13/test_userdict.py::UserDictTest::test_write - RuntimeError: Unexpected success, please remove test/dynamo_expected_failures/CPython313-test_userdict-UserDictTest.test_write

@trichmo just rebase and CI will be green again

@pytorchbot merge

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team