Skip to content

Refactor CUDAAllocatorConfig using ConfigTokenizer#165281

Closed
guangyey wants to merge 5 commits intogh/guangyey/216/basefrom
gh/guangyey/216/head
Closed

Refactor CUDAAllocatorConfig using ConfigTokenizer#165281
guangyey wants to merge 5 commits intogh/guangyey/216/basefrom
gh/guangyey/216/head

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Oct 13, 2025 •
edited by albanD
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165281

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit ba1ba1c with merge base ca96c67 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 11, 2025
Closed
Closed
Closed
Closed
guangyey added a commit that referenced this pull request Oct 13, 2025
@guangyey
Refactor CUDAAllocatorConfig using ConfigTokenizer
3b020b2 
ghstack-source-id: c595fe4
Pull Request resolved: #165281
@guangyey guangyey added the topic: not user facing topic category label Oct 13, 2025
guangyey added a commit that referenced this pull request Oct 13, 2025
@guangyey
Refactor CUDAAllocatorConfig using ConfigTokenizer
8471a06 
ghstack-source-id: ba2fa31
Pull Request resolved: #165281
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2025
This was referenced Oct 13, 2025
Closed
Closed
Closed
Closed
Closed
@guangyey
Update
b16cdfb 
[ghstack-poisoned]
@guangyey guangyey requested a review from albanD October 13, 2025 11:58
@guangyey
Update
8d4daa6 
[ghstack-poisoned]
@albanD
Copy link
Collaborator

albanD commented Oct 13, 2025

@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@guangyey
Update
ca9cb89 
[ghstack-poisoned]
@guangyey
Update
9052477 
[ghstack-poisoned]
@guangyey
Update
ba1ba1c 
[ghstack-poisoned]
@albanD
Copy link
Collaborator

albanD commented Oct 16, 2025

@pytorchbot merge

These should be good!

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 16, 2025

This PR needs to be approved by an authorized maintainer before merge.

@albanD
Copy link
Collaborator

albanD commented Oct 16, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

@guangyey
Copy link
Collaborator Author

guangyey commented Oct 16, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

@guangyey
Copy link
Collaborator Author

guangyey commented Oct 16, 2025

@pytorchbot merge -f "ignore Meta Internal-Only Changes Check since no actual code change"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator! Please try reimporting/rexporting the PR!

Details for Dev Infra team Raised by workflow job

@guangyey
Copy link
Collaborator Author

guangyey commented Oct 16, 2025

Hi @albanD, the merging progress is blocked by Meta Internal-Only Changes Check. I can't force merge via -f flag.

@albanD
Copy link
Collaborator

albanD commented Oct 16, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 16, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@guangyey @Chao1Han
Refactor CUDAAllocatorConfig using ConfigTokenizer (pytorch#165281)
be476df 
* pytorch#165129
Pull Request resolved: pytorch#165281
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 22, 2025
@guangyey @zhudada0120
Refactor CUDAAllocatorConfig using ConfigTokenizer (pytorch#165281)
9b18784 
* pytorch#165129
Pull Request resolved: pytorch#165281
Approved by: https://github.com/albanD
ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
@github-actions github-actions bot deleted the gh/guangyey/216/head branch November 16, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@Aidyn-A Aidyn-A Awaiting requested review from Aidyn-A

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @albanD @pytorchmergebot @pytorchbot