Restore AcceleratorAllocatorConfig to avoid potential regression#165129
Closed
guangyey wants to merge 2 commits intogh/guangyey/212/basefrom
Closed
Restore AcceleratorAllocatorConfig to avoid potential regression#165129guangyey wants to merge 2 commits intogh/guangyey/212/basefrom
guangyey wants to merge 2 commits intogh/guangyey/212/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165129
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 7c5ed43 with merge base ca96c67 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
guangyey
commented
Oct 10, 2025
| auto env##_name = c10::utils::get_env(#env); \ | ||
| if (env##_name.has_value()) { \ | ||
| if (deprecated) { \ | ||
| TORCH_WARN_ONCE(#env " is deprecated, use PYTORCH_ALLOC_CONF instead"); \ |
Collaborator
Author
There was a problem hiding this comment.
TORCH_WARN would introduce overhead. I remove it in case it is the root cause of the regression.
guangyey
commented
Oct 10, 2025
| roundup_power2_divisions_.begin(), | ||
| static_cast<std::vector<size_t>::difference_type>( | ||
| last_index + 1)), | ||
| static_cast<std::vector<size_t>::difference_type>(last_index)), |
Collaborator
Author
There was a problem hiding this comment.
Drop this bug fix to keep consistent with CUDAAllocatorConfig.
This was referenced Oct 10, 2025
This was referenced Oct 13, 2025
Collaborator
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
albanD
approved these changes
Oct 16, 2025
Collaborator
|
Starting merge as part of PR stack under #165281 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #165281 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #165131 Approved by: https://github.com/Skylion007 ghstack dependencies: #165129
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #165135 Approved by: https://github.com/Skylion007 ghstack dependencies: #165129, #165131
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #165136 Approved by: https://github.com/Skylion007 ghstack dependencies: #165129, #165131, #165135
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…orch#165129) # Motivation This PR aims to restore `AcceleratorAllocatorConfig` to avoid the potential regression mentioned in pytorch#160666 (comment) These code change would be reverted in the following PR pytorch#165304 Pull Request resolved: pytorch#165129 Approved by: https://github.com/albanD
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…65131) Pull Request resolved: pytorch#165131 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#165135 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#165136 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
* pytorch#165129 Pull Request resolved: pytorch#165281 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…orch#165129) # Motivation This PR aims to restore `AcceleratorAllocatorConfig` to avoid the potential regression mentioned in pytorch#160666 (comment) These code change would be reverted in the following PR pytorch#165304 Pull Request resolved: pytorch#165129 Approved by: https://github.com/albanD
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…65131) Pull Request resolved: pytorch#165131 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
Pull Request resolved: pytorch#165135 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
Pull Request resolved: pytorch#165136 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
* pytorch#165129 Pull Request resolved: pytorch#165281 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Motivation
This PR aims to restore
AcceleratorAllocatorConfigto avoid the potential regression mentioned in #160666 (comment)These code change would be reverted in the following PR #165304