Register CUDAAllocatorConfig to AcceleratorAllocatorConfig#165131
Closed
guangyey wants to merge 6 commits intogh/guangyey/213/basefrom
Closed
Register CUDAAllocatorConfig to AcceleratorAllocatorConfig#165131guangyey wants to merge 6 commits intogh/guangyey/213/basefrom
guangyey wants to merge 6 commits intogh/guangyey/213/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165131
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit be0c2a8 with merge base ca96c67 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 10, 2025
Skylion007
approved these changes
Oct 10, 2025
This was referenced Oct 13, 2025
Collaborator
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
joshuuuasu
reviewed
Oct 13, 2025
c10/cuda/CUDAAllocatorConfig.h
Outdated
| // Note: keep the parsing order and logic stable to avoid potential | ||
| // performance regressions in internal tests. | ||
| if (!env.has_value()) { | ||
| auto env = c10::utils::get_env("PYTORCH_ALLOC_CONF"); |
Contributor
There was a problem hiding this comment.
Should remove auto.
env = c10::utils::get_env("PYTORCH_ALLOC_CONF");
Collaborator
Author
There was a problem hiding this comment.
Good catch! Thanks.
Collaborator
|
Starting merge as part of PR stack under #165281 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #165281 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #165135 Approved by: https://github.com/Skylion007 ghstack dependencies: #165129, #165131
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Pull Request resolved: #165136 Approved by: https://github.com/Skylion007 ghstack dependencies: #165129, #165131, #165135
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 16, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…65131) Pull Request resolved: pytorch#165131 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#165135 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
Pull Request resolved: pytorch#165136 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
* pytorch#165129 Pull Request resolved: pytorch#165281 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…65131) Pull Request resolved: pytorch#165131 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
Pull Request resolved: pytorch#165135 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
Pull Request resolved: pytorch#165136 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
* pytorch#165129 Pull Request resolved: pytorch#165281 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165129, pytorch#165131, pytorch#165135, pytorch#165136
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):