Refine CUDA BackendStaticInitializer for allocator select#165298
Closed
guangyey wants to merge 6 commits intogh/guangyey/220/basefrom
Closed
Refine CUDA BackendStaticInitializer for allocator select#165298guangyey wants to merge 6 commits intogh/guangyey/220/basefrom
guangyey wants to merge 6 commits intogh/guangyey/220/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165298
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit b473d46 with merge base 556fc09 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 13, 2025
Collaborator
|
@albanD has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
albanD
reviewed
Oct 16, 2025
| break; | ||
| } else { | ||
| // Skip the key and its value | ||
| i = tokenizer.skipKey(i); |
Collaborator
There was a problem hiding this comment.
Isn't something like this missing here?
// handle comma separators between config entries
if (i + 1 < tokenizer.size()) {
tokenizer.checkToken(++i, ",");
}
If so, we should have a specific test to make sure we parse these properly
Collaborator
Author
There was a problem hiding this comment.
You're right, I missed that. Added a test case to cover this scenario.
albanD
approved these changes
Oct 19, 2025
Collaborator
|
Starting merge as part of PR stack under #165304 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 19, 2025
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
…5298) * pytorch#165288 Pull Request resolved: pytorch#165298 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165288, pytorch#165289, pytorch#165291
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Oct 21, 2025
* pytorch#165288 Pull Request resolved: pytorch#165304 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165288, pytorch#165289, pytorch#165291, pytorch#165298
jeffdaily
added a commit
to ROCm/pytorch
that referenced
this pull request
Oct 21, 2025
Fixes pytorch#165872. Forward fix PR pytorch#165298. hipify was causing some symbols to be replaced.
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
…5298) * pytorch#165288 Pull Request resolved: pytorch#165298 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165288, pytorch#165289, pytorch#165291
zhudada0120
pushed a commit
to zhudada0120/pytorch
that referenced
this pull request
Oct 22, 2025
* pytorch#165288 Pull Request resolved: pytorch#165304 Approved by: https://github.com/albanD ghstack dependencies: pytorch#165288, pytorch#165289, pytorch#165291, pytorch#165298
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 22, 2025
Fixes #165872. Forward fix PR #165298. hipify was causing some symbols to be replaced. Pull Request resolved: #166035 Approved by: https://github.com/jeffdaily Co-authored-by: Jeff Daily <jeff.daily@amd.com>
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
ghstack-source-id: ba2b8b9 Pull Request resolved: pytorch/pytorch#165298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):