Skip to content

[build] remove cmake cache and reconfigure again if it is invalid#156958

Closed
XuehaiPan wants to merge 25 commits intogh/XuehaiPan/335/basefrom
gh/XuehaiPan/335/head
Closed

[build] remove cmake cache and reconfigure again if it is invalid#156958
XuehaiPan wants to merge 25 commits intogh/XuehaiPan/335/basefrom
gh/XuehaiPan/335/head

Conversation

@XuehaiPan
Copy link
Copy Markdown
Collaborator

@XuehaiPan XuehaiPan commented Jun 26, 2025 •
edited
Loading

See also:

Stack from ghstack (oldest at bottom):

cc @malfet @seemethere

@XuehaiPan
Update
183057e 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156958

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 27845be with merge base 3df6360 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Jun 26, 2025
@XuehaiPan XuehaiPan added module: build Build system issues release notes: build release notes category topic: build labels Jun 26, 2025
@XuehaiPan XuehaiPan requested review from Skylion007 and rgommers June 26, 2025 14:22
@XuehaiPan
Update
a492c3d 
[ghstack-poisoned]
@XuehaiPan
Update
4ce5855 
[ghstack-poisoned]
XuehaiPan added a commit that referenced this pull request Jun 26, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
3e62c3c 
ghstack-source-id: 2d7940c
Pull-Request: #156958
@XuehaiPan XuehaiPan added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Jun 26, 2025
@XuehaiPan
Update
a01a0b5 
[ghstack-poisoned]
This was referenced Jun 27, 2025
Closed
Closed
@XuehaiPan
Update
c6e8834 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 27, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
388d600 
ghstack-source-id: 999ef3c
Pull-Request: pytorch#156958
@XuehaiPan
Update
6e2047b 
[ghstack-poisoned]
@XuehaiPan
Update
7eb8c95 
[ghstack-poisoned]
@XuehaiPan
Update
2055dd4 
[ghstack-poisoned]
@XuehaiPan
Update
246dd2a 
[ghstack-poisoned]
@XuehaiPan
Update
c5e87d5 
[ghstack-poisoned]
@Skylion007
Copy link
Copy Markdown
Collaborator

Skylion007 commented Jun 30, 2025

This kind of stuff is why we should switch to scikit-build.

@XuehaiPan
Update
2c822cd 
[ghstack-poisoned]
@XuehaiPan
Update
4ff5449 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 1, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
2ecd4e7 
ghstack-source-id: 967655e
Pull-Request: pytorch#156958
@XuehaiPan
Update
27845be 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
b1c9eec 
ghstack-source-id: 90af777
Pull-Request: pytorch#156958
@XuehaiPan XuehaiPan mentioned this pull request Jul 2, 2025
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
eb3099c 
ghstack-source-id: 90af777
Pull-Request: pytorch#156958
Skylion007
Skylion007 reviewed Jul 2, 2025
View reviewed changes
Comment thread tools/setup_helpers/__init__.py
import warnings


def which(thefile: str) -> str | None:
Copy link
Copy Markdown
Collaborator

@Skylion007 Skylion007 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just wrap this with typing_extensions.deprecated?

Copy link
Copy Markdown
Collaborator Author

@XuehaiPan XuehaiPan Jul 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this, but typing-extensions is not installed in CI environment because build isolation is disabled.

Copy link
Copy Markdown
Collaborator

@Skylion007 Skylion007 Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? It's in the build_requires? sigh...

@XuehaiPan XuehaiPan added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 2, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jul 2, 2025
@XuehaiPan
[build] remove cmake cache and reconfigure again if it is invalid
c9c60a6 
ghstack-source-id: 90af777
Pull-Request: pytorch#156958
@XuehaiPan
Copy link
Copy Markdown
Collaborator Author

XuehaiPan commented Jul 2, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jul 2, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions Bot deleted the gh/XuehaiPan/335/head branch August 2, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@rgommers rgommers Awaiting requested review from rgommers

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged module: build Build system issues open source release notes: build release notes category topic: build topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@XuehaiPan @Skylion007 @pytorchmergebot @pytorchbot