Skip to content

[BE] add a minimal linter to check pyproject.toml consistency#156017

Closed
XuehaiPan wants to merge 46 commits intogh/XuehaiPan/281/basefrom
gh/XuehaiPan/281/head
Closed

[BE] add a minimal linter to check pyproject.toml consistency#156017
XuehaiPan wants to merge 46 commits intogh/XuehaiPan/281/basefrom
gh/XuehaiPan/281/head

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 15, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jun 15, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156017

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 1 Unrelated Failure

As of commit a807d60 with merge base 44f5b93 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jun 15, 2025
@XuehaiPan XuehaiPan requested review from Skylion007 and malfet and removed request for Skylion007 June 15, 2025 11:04
@XuehaiPan XuehaiPan added the module: lint Issues related to our Python/C++ lint rules (run by Travis) label Jun 15, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@XuehaiPan XuehaiPan requested a review from Skylion007 June 15, 2025 15:08
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added 14 commits June 28, 2025 21:36
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
XuehaiPan added 3 commits July 3, 2025 02:49
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem that useful? But it doesn't seem harmful either

@ezyang
Copy link
Contributor

ezyang commented Jul 8, 2025

@pytorchbot merge

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 8, 2025

This PR has pending changes requested. Please address the comments and update the PR before merging.

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral)

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: lint Issues related to our Python/C++ lint rules (run by Travis) open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants