[build] remove upper version pin for setuptools<80.0#156049
Closed
XuehaiPan wants to merge 97 commits intogh/XuehaiPan/290/basefrom
Closed
[build] remove upper version pin for setuptools<80.0#156049XuehaiPan wants to merge 97 commits intogh/XuehaiPan/290/basefrom
setuptools<80.0#156049XuehaiPan wants to merge 97 commits intogh/XuehaiPan/290/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156049
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit b9a83c9 with merge base 7441a1b ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 15, 2025
Closed
Collaborator
|
Adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invoking
setup.pycommands is deprecated (especially,python3 setup.py develop), and the support has been removed in the latestsetuptools. See also:setup.py developcommand is disappearing soon fromsetuptools#152276This PR removes the
setuptools>80.0pin because thesetup.pycommand migration has been resolved by previous PRs in the stack:[build] modernize build-backend:
setuptools.build_meta:__legacy__->setuptools.build_meta#155998[build] modernize build-frontend:
python setup.py develop/install->[uv ]pip install --no-build-isolation [-e ].#156027python setup.py develop->python -m pip install --no-build-isolation -v -e .python setup.py install->python -m pip install --no-build-isolation -v .Stack from ghstack (oldest at bottom):
setuptools<80.0#156049setuptools>=77to enable PEP 639 #158104cc @malfet @seemethere