Skip to content

[build] pin setuptools>=77 to enable PEP 639#158104

Open
XuehaiPan wants to merge 74 commits intogh/XuehaiPan/365/basefrom
gh/XuehaiPan/365/head
Open

[build] pin setuptools>=77 to enable PEP 639#158104
XuehaiPan wants to merge 74 commits intogh/XuehaiPan/365/basefrom
gh/XuehaiPan/365/head

Conversation

@XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jul 11, 2025

PEP 639: peps.python.org/pep-0639

setuptools v77 adds PEP 639 support for SPDX expression as package.license in pyproject.toml and also deprecated TOML-table-based package.license. That depression will be converted to an error in the future.

Note that setuptools<77 does not support SPDX-based package.license while setuptools>=77 will error for non-SPDX-based package.license in the future. We need an explicit version pin for setuptools>=77 (or pin setuptools<77).

See also:

Stack from ghstack (oldest at bottom):

cc @malfet @seemethere @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

[ghstack-poisoned]
@XuehaiPan XuehaiPan requested review from a team and jeffdaily as code owners July 11, 2025 05:53
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158104

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 8 Cancelled Jobs, 2 Unrelated Failures

As of commit 846a222 with merge base 2b8b4ff (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@XuehaiPan XuehaiPan added module: build Build system issues release notes: build release notes category topic: build labels Jul 11, 2025
@XuehaiPan XuehaiPan marked this pull request as ready for review July 11, 2025 10:17
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ci-test-showlocals Show local variables on test failures ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/inductor ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/trunk Trigger trunk jobs on your pull request ciflow/win-arm64 Trigger Windows Arm64 CI Workflows keep-going Don't stop on first failure, keep running tests until the end Merged module: build Build system issues module: dynamo open source release notes: build release notes category release notes: quantization release notes category release notes: releng release notes category Reverted topic: build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Inductor-perf-nighly-macos started to fail to install torchvision

10 participants