[build] pin setuptools>=77 to enable PEP 639#158104
Open
XuehaiPan wants to merge 74 commits intogh/XuehaiPan/365/basefrom
Open
[build] pin setuptools>=77 to enable PEP 639#158104XuehaiPan wants to merge 74 commits intogh/XuehaiPan/365/basefrom
setuptools>=77 to enable PEP 639#158104XuehaiPan wants to merge 74 commits intogh/XuehaiPan/365/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158104
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 8 Cancelled Jobs, 2 Unrelated FailuresAs of commit 846a222 with merge base 2b8b4ff ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 639: peps.python.org/pep-0639
setuptoolsv77 adds PEP 639 support for SPDX expression aspackage.licenseinpyproject.tomland also deprecated TOML-table-basedpackage.license. That depression will be converted to an error in the future.Note that
setuptools<77does not support SPDX-basedpackage.licensewhilesetuptools>=77will error for non-SPDX-basedpackage.licensein the future. We need an explicit version pin forsetuptools>=77(or pinsetuptools<77).See also:
project.licensedeprecation if v77 unavailable pypa/setuptools#4903Stack from ghstack (oldest at bottom):
setuptools>=77to enable PEP 639 #158104cc @malfet @seemethere @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela