[build] modernize build-frontend: `python setup.py develop/install` -> `[uv ]pip install --no-build-isolation [-e ].` by XuehaiPan · Pull Request #156027 · pytorch/pytorch

XuehaiPan · 2025-06-15T16:22:39Z

Modernize the development installation:

# python setup.py develop
python -m pip install --no-build-isolation -e .

# python setup.py install
python -m pip install --no-build-isolation .

Now, the python setup.py develop is a wrapper around python -m pip install -e . since setuptools>=80.0:

Rely on pip for setup.py develop pypa/setuptools#4955

python setup.py install is deprecated and will emit a warning during run. The warning will become an error on October 31, 2025.

https://github.com/pypa/setuptools/blob/9c4d383631d3951fcae0afd73b5d08ff5a262976/setuptools/command/install.py#L58-L67

SetuptoolsDeprecationWarning.emit(
    "setup.py install is deprecated.",
    """
    Please avoid running ``setup.py`` directly.
    Instead, use pypa/build, pypa/installer or other
    standards-based tools.
    """,
    see_url="https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html",
    due_date=(2025, 10, 31),
)

Overhaul for better visibility of warnings pypa/setuptools#3849

Additional Resource:

Why you shouldn't invoke setup.py directly

Stack from ghstack (oldest at bottom):

cc @seemethere @malfet @osalpekar @atalman

[ghstack-poisoned]

pytorch-bot · 2025-06-15T16:22:43Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156027

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 872688b with merge base 476874b ():

NEW FAILURES - The following jobs have failed:

Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64) (gh)
Process completed with exit code 2.
Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64) (gh)
Process completed with exit code 2.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

…> `[uv ]pip install[ -e] .` Modernize the development installation: ```bash python -m pip install -e . python -m pip install . ``` ghstack-source-id: 6127c08 Pull-Request: pytorch#156027

[ghstack-poisoned]

XuehaiPan · 2025-07-05T07:19:51Z

The Docker image build failure is due to the non-existence of pip index URL for stable torch cu129, which is unrelated to this PR.

[ghstack-poisoned]

ezyang · 2025-07-09T03:06:47Z

@pytorchbot merge -r

pytorchmergebot · 2025-07-09T03:08:22Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

[ghstack-poisoned]

pytorchmergebot · 2025-07-09T03:08:36Z

Successfully rebased gh/XuehaiPan/283/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/156027)

pytorchmergebot · 2025-07-09T03:09:58Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-07-09T03:20:58Z

Merge failed

Reason: 2 jobs have failed, first few of them are: Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64), Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64)

Details for Dev Infra team

Raised by workflow job

XuehaiPan · 2025-07-09T03:23:17Z

@pytorchbot merge -i

pytorchmergebot · 2025-07-09T03:25:09Z

Merge started

Your change will be merged while ignoring the following 2 checks: Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64), Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-07-09T09:23:39Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

XuehaiPan · 2025-07-09T09:24:29Z

@pytorchbot merge -i

pytorchmergebot · 2025-07-09T09:26:18Z

Merge started

Your change will be merged while ignoring the following 2 checks: Build Official Docker Images / build (12.9, 12.9.1, 9, runtime, linux/amd64), Build Official Docker Images / build (12.9, 12.9.1, 9, devel, linux/amd64)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

albanD · 2025-07-22T14:41:58Z

@XuehaiPan @ezyang doesn't this new recommendation break ccache due to folder randomization?
Why do we recommend that??

rgommers · 2025-07-22T16:02:06Z

It shouldn't, pip just defaults to building in the build folder nowadays, that was changed several years ago. uv does the same.

albanD · 2025-07-22T16:05:57Z

But then I'm surprised of the very big warning that was added to vllm recently: https://docs.vllm.ai/en/latest/getting_started/installation/gpu.html#full-build-with-compilation ?

rgommers · 2025-07-22T16:19:32Z

Those vllm instructions omit --no-build-isolation in their default instructions, which is a really bad idea: it re-installs all build dependencies on each invocation into a temporary venv, and yes that does change to a random path which will break ccache.

Doing an editable build with build isolation never really makes sense when dealing with compiled code, you'll never be able to do an incremental build.

Update

bbe70f0

[ghstack-poisoned]

XuehaiPan requested a review from a team as a code owner June 15, 2025 16:22

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jun 15, 2025

XuehaiPan mentioned this pull request Jun 15, 2025

[build] modernize build-backend: setuptools.build_meta:__legacy__ -> setuptools.build_meta #155998

Closed

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Jun 15, 2025

This was referenced Jun 15, 2025

[BE] add a minimal linter to check pyproject.toml consistency #156017

Closed

[BE] fix PYPROJECT linting errors in test/ and tools/ #156021

Closed

[BE][Easy] pin setuptools>=77 for PEP-639 support #155999

Closed

pytorchbot added the open source label Jun 15, 2025

Update

278b30e

[ghstack-poisoned]

Update

7e10ce3

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jun 15, 2025

[RFC] Migrate to modern Python build system and replace setup.py commands with their modern alternatives #156029

Closed

Update

6386d08

[ghstack-poisoned]

Update

0822609

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 3, 2025

[AOTI] Fix AOT inductor CMake build dependency order #157557

Closed

XuehaiPan added 5 commits July 4, 2025 00:52

Update

19f769b

[ghstack-poisoned]

Update

41445fd

[ghstack-poisoned]

Update

d14456c

[ghstack-poisoned]

Update

76c878d

[ghstack-poisoned]

Update

20466d8

[ghstack-poisoned]

Update

db633c6

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 8, 2025

[build] pin setuptools>=70.1.0 for integrated bdist_wheel command #157783

Closed

zklaus mentioned this pull request Jul 8, 2025

[RFC] Replace setuptools build backend with scikit-build-core #157807

Open

ezyang approved these changes Jul 9, 2025

View reviewed changes

Update

872688b

[ghstack-poisoned]

XuehaiPan mentioned this pull request Jul 9, 2025

[BE][Easy] remove unused build-time dependency astunparse and change astunparse.unparse -> ast.unparse #157907

Closed

jinsun-yoo mentioned this pull request Jul 28, 2025

Lingering reference to setup.py in CONTRIBUTING.md #159234

Open

This was referenced Aug 11, 2025

Replace setup.py develop with pip install -e #156710

Closed

Replace setup.py install with pip install #156711

Closed

Conversation

XuehaiPan commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jun 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156027

❌ 2 New Failures

Uh oh!

XuehaiPan commented Jul 5, 2025

Uh oh!

ezyang commented Jul 9, 2025

Uh oh!

pytorchmergebot commented Jul 9, 2025

Uh oh!

pytorchmergebot commented Jul 9, 2025

Uh oh!

pytorchmergebot commented Jul 9, 2025

Merge started

Uh oh!

pytorchmergebot commented Jul 9, 2025

Merge failed

Uh oh!

XuehaiPan commented Jul 9, 2025

Uh oh!

pytorchmergebot commented Jul 9, 2025

Merge started

Uh oh!

pytorchmergebot commented Jul 9, 2025

Uh oh!

XuehaiPan commented Jul 9, 2025

Uh oh!

pytorchmergebot commented Jul 9, 2025

Merge started

Uh oh!

albanD commented Jul 22, 2025

Uh oh!

rgommers commented Jul 22, 2025

Uh oh!

albanD commented Jul 22, 2025

Uh oh!

rgommers commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

XuehaiPan commented Jun 15, 2025 •

edited

Loading

pytorch-bot bot commented Jun 15, 2025 •

edited

Loading

rgommers commented Jul 22, 2025 •

edited

Loading