[EZ] Do not checkout builder for Linux builds#142282
Closed
malfet wants to merge 3 commits into
Closed
Conversation
This was referenced Dec 7, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142282
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 38 New FailuresAs of commit 4898673 with merge base 6e203ae ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
@malfet Please rebase and also bring, check_binary.sh https://github.com/pytorch/pytorch/blob/main/.circleci/scripts/binary_linux_test.sh#L93 Probably good place is here: https://github.com/pytorch/pytorch/tree/main/.ci/pytorch |
Contributor
Author
It's not used from build step, and I plan to keep test as is for now |
Collaborator
|
@malfet builder is still used in test step. Why not eliminate dependency on builder completely ? I see we are still getting builder here: https://github.com/pytorch/pytorch/actions/runs/12240753927/job/34146607849?pr=142282#step:11:40 |
Contributor
Author
Yes, this is expected, I can do it in the followup PRs, this PR is specifically about |
Contributor
Author
|
@pytorchbot merge -f "Lint wheel builds are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
This broke rocm nightly builds. |
Contributor
Collaborator
|
I believe this should take care of rocm breakage due to missing check_binary.sh script: #142482 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2024
Fixes #142485 The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened: 1. #142294 landed yesterday to build ROCm on 3.13, but the PR had a landrace with #142282 in the generated workflow file 2. The trunk lint check caught that in https://github.com/pytorch/pytorch/blob/main/.github/scripts/report_git_status.sh#L2 3. However, the script also attempted to print the difference with `git diff .github/workflows`. This command was the one that stuck because `git diff` uses page by default and requires a prompt to display the next page ¯\_(ツ)_/¯ It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this. Bonus: I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure `Credentials could not be loaded, please check your action inputs` Pull Request resolved: #142476 Approved by: https://github.com/wdvr
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 12, 2024
Follow Up after: #142282 Remove Checkout pytorch/builder for Linux Binary Builds I believe we where not using builder already. Hence remove this checkout. We should be using scripts from this folder: ``` /pytorch/.ci/${{ inputs.PACKAGE_TYPE }}/build.sh ``` TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo Pull Request resolved: #143125 Approved by: https://github.com/kit1980
kit1980
added a commit
that referenced
this pull request
Dec 12, 2024
…43131) Follow Up after: #142282 Remove Checkout pytorch/builder for Linux Binary Builds I believe we where not using builder already. Hence remove this checkout. We should be using scripts from this folder: ``` /pytorch/.ci/${{ inputs.PACKAGE_TYPE }}/build.sh ``` TODO: Will followup with removing BUILDER_ROOT everywhere from PyTorch repo Pull Request resolved: #143125 Approved by: https://github.com/kit1980 Co-authored-by: atalman <atalman@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
binary_macos_test.sh#142382All logic should have been migrated to .ci/manywheel folder from builder repo a while back