Enable py3.13 wheels for ROCm#142294
Closed
jithunnair-amd wants to merge 4 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142294
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New FailuresAs of commit 985aa6c with merge base c863227 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
Author
|
@atalman ROCm py3.13 binary wheel jobs passed. Please approve and merge. I would like to Cherry pick this for PyTorch 2.6 so that we can enable 3.13 wheels for ROCm for the latest release. |
Contributor
|
@pytorchbot merge -f 'No need to run trunk jobs, ROCm build for 3.13 and 3.13t have passed' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Dec 10, 2024
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2024
Fixes #142485 The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened: 1. #142294 landed yesterday to build ROCm on 3.13, but the PR had a landrace with #142282 in the generated workflow file 2. The trunk lint check caught that in https://github.com/pytorch/pytorch/blob/main/.github/scripts/report_git_status.sh#L2 3. However, the script also attempted to print the difference with `git diff .github/workflows`. This command was the one that stuck because `git diff` uses page by default and requires a prompt to display the next page ¯\_(ツ)_/¯ It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this. Bonus: I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure `Credentials could not be loaded, please check your action inputs` Pull Request resolved: #142476 Approved by: https://github.com/wdvr
37 tasks
atalman
added a commit
to pytorch/test-infra
that referenced
this pull request
Dec 17, 2024
Follow up after: pytorch/pytorch#142294
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @jeffdaily @sunway513 @pruthvistony @ROCmSupport @dllehr-amd @jataylo @hongxiayang @naromero77amd