Fix timeout check workflow lint job#142476
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142476
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9f82330 with merge base d3d1a78 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
why is the generated file changed, but not the source file? Did we forget to generate on a previous commit?
|
@pytorchbot merge -f 'Lint jobs have passed' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| PYTHONPATH=$(pwd) pytest tools/test/test_*.py | ||
| PYTHONPATH=$(pwd) pytest .github/scripts/test_*.py |
There was a problem hiding this comment.
Isn't this only setting they PYTHONPATH env var, resulting in no test files being executed or discovered?
There was a problem hiding this comment.
Good catch! The test works but one test there is not working with pytest https://github.com/pytorch/pytorch/actions/runs/12264094674/job/34217191327?pr=142476#step:14:135, so let me fix it
A follow-up from #142476 (comment) where some tests are not discovered correctly by pytest ### Testing https://github.com/pytorch/pytorch/actions/runs/12287448581/job/34289531307?pr=143052#step:14:162 shows the correct number of tests now Pull Request resolved: #143052 Approved by: https://github.com/ZainRizvi
Fixes #142485
The workflow check lint job timed out in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/12261226178/job/34207762939, and here was what happened:
git diff .github/workflows. This command was the one that stuck becausegit diffuses page by default and requires a prompt to display the next page ¯_(ツ)_/¯It took so long to debug this because a timeout Nova GHA doesn't print any progress. I'll create an issue for this.
Bonus:
I also fix the broken print from test tool lint job that confuses GitHub https://github.com/pytorch/pytorch/actions/runs/12261226178 with an annotation failure
Credentials could not be loaded, please check your action inputs