Do not use builder repo for MacOS builds#142277
Closed
malfet wants to merge 2 commits into
Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/142277
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 30 New FailuresAs of commit 97e72bc with merge base 6e203ae ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Collaborator
|
I believe we still need to migrate couple of files from builder: This : |
Contributor
Author
|
@pytorchbot merge -f "Mac builds are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
According to https://github.com/search?type=code&q=binary_macos_test.sh+repo%3Apytorch%2Fpytorch (and grep in the repo) it's not used anywhere Pull Request resolved: #142382 Approved by: https://github.com/atalman ghstack dependencies: #142276, #142277
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 9, 2024
All logic should have been migrated to .ci/manywheel folder from builder repo a while back Pull Request resolved: #142282 Approved by: https://github.com/atalman ghstack dependencies: #142276, #142277, #142382
malfet
added a commit
to pytorch/builder
that referenced
this pull request
Dec 18, 2024
It's been migrated to pytorch/pytorch by pytorch/pytorch#142277
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
binary_macos_test.sh#142382Added https://github.com/pytorch/builder/blob/c7564f31f7e1e5c8fab2f4ce511b2d73a3afbe60/wheel/build_wheel.sh to
.ci/wheel/folderCommented out call to https://github.com/pytorch/builder/blob/39532891a083f0929d3b46f690a3ea719de6bf76/run_tests.sh, because since 2018 this script just checked that tests folder is there and exited, as there are no way to run all pytorch tests in single shard, see this logic:
#123390 is a misread attempt to interpret above-mentioned logic, as run_tests will be skipped if
${SKIP_ALL_TESTS}is a non-empty string