[1/2] Remove caffe2 db and distributed from build system#125092
Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
Closed
[1/2] Remove caffe2 db and distributed from build system#125092cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125092
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a8a048a with merge base d6052a3 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
@cyyever - how's this one going? |
Collaborator
Author
19bc783 to
77219eb
Compare
e630638 to
0a05dcd
Compare
Collaborator
Author
|
@r-barnes Now I think we can also merge it before the python PR. |
malfet
approved these changes
May 1, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
Deleted code is tested code
Collaborator
Author
Do you mean deleted code in torch/binaries or other locations? |
Collaborator
Author
|
@r-barnes Help merge it once you are ready? |
49990ea to
4d88b14
Compare
Collaborator
Author
|
@pytorchmergebot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / macos-12-py3-arm64 / test (default, 3, 3, macos-m1-stable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
May 5, 2024
This PR follows #125092 to remove caffe2/db/* and caffe2/distributed/* . Pull Request resolved: #125533 Approved by: https://github.com/kit1980
Contributor
|
@cyyever - it would have been nice if you'd waited to merge this one: untangling it is going to be messy. |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 17, 2024
That were deleted by #125092 Fixes #136199 Pull Request resolved: #136204 Approved by: https://github.com/albanD, https://github.com/seemethere
Chao1Han
pushed a commit
to Chao1Han/pytorch
that referenced
this pull request
Sep 20, 2024
That were deleted by pytorch#125092 Fixes pytorch#136199 Pull Request resolved: pytorch#136204 Approved by: https://github.com/albanD, https://github.com/seemethere
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 18, 2025
Which is a vestige of caffe2 days and was no-op since #125092 Pull Request resolved: #149360 Approved by: https://github.com/atalman, https://github.com/cyyever, https://github.com/seemethere, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to decompose #122527 into a smaller one. Caffe2 db, distributed build scripts and some binaries have been removed.
To be noted, this was inspired and is co-dev with @r-barnes.
cc @malfet @seemethere @ezyang @gchanan @albanD