Skip to content

[EZ][Docker] Remove install_db.sh#149360

Closed
malfet wants to merge 1 commit intogh/malfet/236/basefrom
gh/malfet/236/head
Closed

[EZ][Docker] Remove install_db.sh#149360
malfet wants to merge 1 commit intogh/malfet/236/basefrom
gh/malfet/236/head

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Mar 17, 2025 •
edited by pytorch-bot bot
Loading

@malfet
Update
084b824 
[ghstack-poisoned]
@malfet malfet requested a review from jeffdaily as a code owner March 17, 2025 23:46
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Mar 17, 2025
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/149360

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Cancelled Jobs, 1 Unrelated Failure

As of commit 084b824 with merge base 523bffd (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Mar 17, 2025
@malfet
[EZ][Docker] Remove install_db.sh
0eee74c 
Which is a vestige of caffe2 days and was no-op since #125092

ghstack-source-id: 48d8120
Pull Request resolved: #149360
@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Mar 17, 2025
@malfet malfet requested a review from a team March 17, 2025 23:47
@malfet malfet removed the module: rocm AMD GPU support for Pytorch label Mar 17, 2025
atalman
atalman approved these changes Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, Are we sure this is not used in domain builds ?

@cyyever
Copy link
Copy Markdown
Collaborator

cyyever commented Mar 18, 2025

I want to remove it since last year.

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

jithunnair-amd commented Mar 18, 2025

@malfet @atalman We are aware of an issue with building ROCm manywheel/libtorch images due to the failure in the step involving install_rocm_drm.sh: this is because https://gitlab.freedesktop.org/mesa/drm.git/ is down. We are exploring options to workaround this temporary issue.

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Mar 18, 2025

@malfet @atalman We are aware of an issue with building ROCm manywheel/libtorch images due to the failure in the step involving install_rocm_drm.sh: this is because https://gitlab.freedesktop.org/mesa/drm.git/ is down. We are exploring options to workaround this temporary issue.

Thank you. I wonder if I should create a preemptive CI-SEV as looks like any docker update might got blocked for the entire week, per statement on https://gitlab.freedesktop.org:

Currently planned outage: 2025-03-16 -> 2025-03-22

@jithunnair-amd
Copy link
Copy Markdown
Collaborator

jithunnair-amd commented Mar 18, 2025

@malfet @atalman We are aware of an issue with building ROCm manywheel/libtorch images due to the failure in the step involving install_rocm_drm.sh: this is because https://gitlab.freedesktop.org/mesa/drm.git/ is down. We are exploring options to workaround this temporary issue.

Thank you. I wonder if I should create a preemptive CI-SEV as looks like any docker update might got blocked for the entire week, per statement on https://gitlab.freedesktop.org:

Currently planned outage: 2025-03-16 -> 2025-03-22

May not be needed: I have a PR to use a mirror that seems to work in my local testing: #149380

@malfet
Copy link
Copy Markdown
Contributor Author

malfet commented Mar 18, 2025

@pytorchbot merge -f "Let's test in prod, looks like gitlab.freedesktop.org is functional again"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 18, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/malfet/236/head branch April 22, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@atalman atalman atalman approved these changes

@cyyever cyyever cyyever approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily

Assignees

No one assigned

Labels

Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@malfet @cyyever @jithunnair-amd @pytorchmergebot @seemethere @Skylion007 @atalman @facebook-github-bot