Skip to content

[2/2] Remove Caffe2 db and distributed code#125533

Closed
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:caffe2_db2
Closed

[2/2] Remove Caffe2 db and distributed code#125533
cyyever wants to merge 1 commit intopytorch:mainfrom
cyyever:caffe2_db2

Conversation

@cyyever
Copy link
Copy Markdown
Collaborator

@cyyever cyyever commented May 4, 2024 •
edited by pytorch-bot bot
Loading

This PR follows #125092 to remove caffe2/db/* and caffe2/distributed/* .

cc @ezyang @gchanan

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented May 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125533

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 2228dc9 with merge base 7f0c5eb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the caffe2 label May 4, 2024
@cyyever cyyever changed the title Remove Caffe2 db and distributed code [2/2] Remove Caffe2 db and distributed code May 4, 2024
@cyyever cyyever requested review from ezyang, kit1980, malfet and r-barnes May 4, 2024 15:05
@cyyever cyyever added the module: bc-breaking Related to a BC-breaking change label May 4, 2024
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 5, 2024

@pytorchmergebot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 5, 2024
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 5, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 5, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 5, 2024

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@cyyever cyyever added release notes: releng release notes category release notes: build release notes category labels May 5, 2024
@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 5, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 5, 2024

Merge started

Your change will be merged while ignoring the following 4 checks: BC Lint / bc_linter, pull / linux-focal-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge.nvidia.gpu), pull / linux-focal-cpu-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, linux.4xlarge), trunk / caffe2-linux-jammy-py3.8-gcc11 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@cyyever cyyever force-pushed the caffe2_db2 branch 2 times, most recently from 5b5dcfb to ca14b44 Compare May 5, 2024 02:04
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 5, 2024

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@cyyever
Copy link
Copy Markdown
Collaborator Author

cyyever commented May 5, 2024

@pytorchmergebot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented May 5, 2024

Merge started

Your change will be merged while ignoring the following 1 checks: BC Lint / bc_linter

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented May 16, 2024

@izaitsevfb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cyyever cyyever deleted the caffe2_db2 branch May 30, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet Awaiting requested review from malfet

@ezyang ezyang Awaiting requested review from ezyang

@r-barnes r-barnes Awaiting requested review from r-barnes

1 more reviewer

@kit1980 kit1980 kit1980 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

caffe2 ciflow/trunk Trigger trunk jobs on your pull request Merged module: bc-breaking Related to a BC-breaking change open source release notes: build release notes category release notes: releng release notes category topic: bc breaking topic category topic: build topic: deprecation topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cyyever @pytorchmergebot @facebook-github-bot @kit1980 @pytorchbot