Closed
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/122527
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 2 Unrelated FailuresAs of commit edf8e40 with merge base 2ac739c ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jithunnair-amd
approved these changes
Mar 22, 2024
bigfootjon
approved these changes
Mar 22, 2024
Member
bigfootjon
left a comment
There was a problem hiding this comment.
LGTM, Please make sure to coordinate with the pytorch releng oncall to have them skip this commit in Diff Train
Contributor
Author
|
Cleaning out references to |
malfet
approved these changes
Mar 22, 2024
Contributor
malfet
left a comment
There was a problem hiding this comment.
If CI is green, lgtm, though you probably want to keep caffe2 building workflow (part of ciflow/trunk)
f4dbc85 to
69668dc
Compare
69668dc to
da60efd
Compare
Contributor
mikaylagawarecki
left a comment
There was a problem hiding this comment.
I think serialization depends on caffe2/serialize/ which seems to be deleted in this PR
1ff20f0 to
8dae90d
Compare
Contributor
Author
|
@mikaylagawarecki - I've brought |
pytorch-bot bot
pushed a commit
that referenced
this pull request
May 3, 2024
This PR tries to decompose #122527 into a smaller one. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: #125038 Approved by: https://github.com/malfet
petrex
pushed a commit
to petrex/pytorch
that referenced
this pull request
May 3, 2024
This PR tries to decompose pytorch#122527 into a smaller one. Caffe2 image and video folders are removed along with the related CMake code. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: pytorch#125045 Approved by: https://github.com/eqy, https://github.com/albanD
pytorchmergebot
pushed a commit
that referenced
this pull request
May 4, 2024
This PR tries to decompose #122527 into a smaller one. Caffe2 db, distributed and some binaries have been removed. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: #125092 Approved by: https://github.com/malfet
pytorchmergebot
pushed a commit
that referenced
this pull request
May 10, 2024
This PR tries to decompose #122527 into a smaller one. Caffe2 python build scripts were removed and some tensorboard code using Caffe2 was removed too. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: #125143 Approved by: https://github.com/r-barnes, https://github.com/albanD
tinglvv
pushed a commit
to tinglvv/pytorch
that referenced
this pull request
May 14, 2024
This PR tries to decompose pytorch#122527 into a smaller one. Caffe2 python build scripts were removed and some tensorboard code using Caffe2 was removed too. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: pytorch#125143 Approved by: https://github.com/r-barnes, https://github.com/albanD
5a44937 to
edf8e40
Compare
albanD
approved these changes
May 24, 2024
This was referenced Jul 22, 2024
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Meta internal no longer syncs to caffe2/ and it is no longer a major thrust of development.
OSS tests have been disabled for caffe2/, so we don't know if changes to it are safe.
Let's remove it from master so we can focus on what's important: PyTorch.
cc @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @snadampal @albanD