Remove caffe2 contrib and experiments#125038
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/125038
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f3a457a with merge base ce503c1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
LGTM if it passes the CI, but it should be landed as co-dev
cc: @r-barnes @izaitsevfb
|
@cyyever - I'll be helping you land this by disabling an internal sync once this is ready. Could you ping me when you have passing tests? |
|
Also, #122527 only has 4 test failures now, so we might be able to pursue that directly. |
de98193 to
3e1110a
Compare
|
@r-barnes It is ready. |
|
@r-barnes You mentioned that META has been not synced with Caffe2, so it may be safe to merge without breaking META builds. |
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@cyyever - I did ask you to ping me when this was ready. Landing it without getting a response from me is causing problems internally :-( |
|
Desyncing with D56711054. |
|
I'll post here again when the desync has landed. |
|
D56711054 landed, so we're good internally. |
This PR tries to decompose pytorch#122527 into a smaller one. To be noted, this was inspired and is co-dev with @r-barnes. Pull Request resolved: pytorch#125038 Approved by: https://github.com/malfet
This PR tries to decompose #122527 into a smaller one.
To be noted, this was inspired and is co-dev with @r-barnes.
cc @malfet @seemethere @jbschlosser @gujinghui @PenghuiCheng @XiaobingSuper @jianyuh @jgong5 @mingfeima @sanchitintel @ashokei @jingxu10 @min-jean-cho @yanbing-j @Guobing-Chen @Xia-Weiwen @albanD