Revert "[dynamo] Guard on HAS_GRAPH_BREAKS if graph breaks are present (i.e. cache miss if compiled object requires nopython) (#114073)"#115384
Closed
davidberard98 wants to merge 2 commits intogh/davidberard98/246/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/115384
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1909655 with merge base 72e58a7 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 7, 2023
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
…ks are present (i.e. cache miss if compiled object requires nopython) (#114073)"" This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) [ghstack-poisoned]
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
malfet
approved these changes
Dec 9, 2023
Contributor
Author
|
@davidberard98 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 10, 2023
#115401) This reverts commit b62230a. Differential Revision: [D52001024](https://our.internmc.facebook.com/intern/diff/D52001024) Pull Request resolved: #115401 Approved by: https://github.com/malfet ghstack dependencies: #115384
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2023
…5385) This reverts commit 78318d0. Differential Revision: [D51959268](https://our.internmc.facebook.com/intern/diff/D51959268) Pull Request resolved: #115385 Approved by: https://github.com/malfet ghstack dependencies: #115384, #115401
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 11, 2023
This reverts commit 5927e9c. Differential Revision: [D51959266](https://our.internmc.facebook.com/intern/diff/D51959266) Pull Request resolved: #115386 Approved by: https://github.com/yanboliang, https://github.com/malfet ghstack dependencies: #115384, #115401, #115385
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
…" (pytorch#115385) This reverts commit 78318d0. Differential Revision: [D51959268](https://our.internmc.facebook.com/intern/diff/D51959268) Pull Request resolved: pytorch#115385 Approved by: https://github.com/malfet ghstack dependencies: pytorch#115384, pytorch#115401
guilhermeleobas
pushed a commit
to guilhermeleobas/pytorch
that referenced
this pull request
Dec 18, 2023
This reverts commit 5927e9c. Differential Revision: [D51959266](https://our.internmc.facebook.com/intern/diff/D51959266) Pull Request resolved: pytorch#115386 Approved by: https://github.com/yanboliang, https://github.com/malfet ghstack dependencies: pytorch#115384, pytorch#115401, pytorch#115385
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…ent (i.e. cache miss if compiled object requires nopython) (pytorch#114073)" (pytorch#115384) This reverts commit 0bb29f9. Differential Revision: [D51959267](https://our.internmc.facebook.com/intern/diff/D51959267) Pull Request resolved: pytorch#115384 Approved by: https://github.com/malfet
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…113901)" (pytorch#115401) This reverts commit b62230a. Differential Revision: [D52001024](https://our.internmc.facebook.com/intern/diff/D52001024) Pull Request resolved: pytorch#115401 Approved by: https://github.com/malfet ghstack dependencies: pytorch#115384
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
…" (pytorch#115385) This reverts commit 78318d0. Differential Revision: [D51959268](https://our.internmc.facebook.com/intern/diff/D51959268) Pull Request resolved: pytorch#115385 Approved by: https://github.com/malfet ghstack dependencies: pytorch#115384, pytorch#115401
dmenig
pushed a commit
to dmenig/pytorch
that referenced
this pull request
Dec 21, 2023
This reverts commit 5927e9c. Differential Revision: [D51959266](https://our.internmc.facebook.com/intern/diff/D51959266) Pull Request resolved: pytorch#115386 Approved by: https://github.com/yanboliang, https://github.com/malfet ghstack dependencies: pytorch#115384, pytorch#115401, pytorch#115385
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
OptimizeCtxfield - export (#113901)" #115401HAS_GRAPH_BREAKSif graph breaks are present (i.e. cache miss if compiled object requires nopython) (#114073)" #115384This reverts commit 0bb29f9.
Differential Revision: D51959267
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng